Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI support relies on removed C++ bindings #10

Open
lexming opened this issue Jan 17, 2023 · 0 comments
Open

MPI support relies on removed C++ bindings #10

lexming opened this issue Jan 17, 2023 · 0 comments

Comments

@lexming
Copy link

lexming commented Jan 17, 2023

There are 3 points in input.C where MPI is handled through its C++ bindings. These can be found at lines 1932, 2304 and 2694 and they all perform a very similar broadcast. The snippet of the first one follows:

StackBlock/input.C

Lines 1932 to 1944 in f95317b

#ifndef SERIAL
MPI::COMM_WORLD.Barrier();
long intdim = oneIntegralMem+twoIntegralMem;
long maxint = 26843540; //mpi cannot transfer more than these number of doubles
long maxIter = intdim/maxint;
for (int i=0; i<maxIter; i++) {
MPI::COMM_WORLD.Bcast(v1.set_data()+i*maxint, maxint, MPI_DOUBLE, 0);
MPI::COMM_WORLD.Barrier();
}
MPI::COMM_WORLD.Bcast(v1.set_data()+(maxIter)*maxint, oneIntegralMem+twoIntegralMem - maxIter*maxint, MPI_DOUBLE, 0);
MPI::COMM_WORLD.Barrier();
#endif

The issue is that the C++ bindings were deprecated in MPI 2.2 (almost 10 years ago) and removed in MPI 3.0, which makes StackBlock very difficult to compile in a modern MPI stack. Since StackBlock already uses Boost:MPI to leverage most of its MPI communications, the solution would be to move these 3 broadcast to Boost:MPI as well and delete the include on mpi.h altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant