Skip to content

Commit e226ca4

Browse files
authored
fix(sanity): discard draft permission check (#8711)
1 parent 2693a76 commit e226ca4

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

packages/sanity/src/core/releases/components/documentHeader/contextMenu/VersionContextMenu.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {MenuGroup} from '../../../../../ui-components/menuGroup/MenuGroup'
88
import {MenuItem} from '../../../../../ui-components/menuItem/MenuItem'
99
import {useTranslation} from '../../../../i18n/hooks/useTranslation'
1010
import {useDocumentPairPermissions} from '../../../../store/_legacy/grants/documentPairPermissions'
11-
import {getPublishedId, isDraftId, isPublishedId} from '../../../../util/draftUtils'
11+
import {getPublishedId, isPublishedId} from '../../../../util/draftUtils'
1212
import {useReleasesUpsell} from '../../../contexts/upsell/useReleasesUpsell'
1313
import {type ReleaseDocument} from '../../../store/types'
1414
import {useReleaseOperations} from '../../../store/useReleaseOperations'
@@ -60,12 +60,14 @@ export const VersionContextMenu = memo(function VersionContextMenu(props: {
6060
const {createRelease} = useReleaseOperations()
6161
const [hasCreatePermission, setHasCreatePermission] = useState<boolean | null>(null)
6262

63-
const releaseId = isVersion ? fromRelease : documentId
6463
const [permissions, isPermissionsLoading] = useDocumentPairPermissions({
6564
id: getPublishedId(documentId),
6665
type,
67-
version: releaseId,
68-
permission: isDraftId(documentId) ? 'discardDraft' : 'discardVersion',
66+
version: isVersion ? fromRelease : undefined,
67+
// Note: the result of this discard permission check is disregarded for the published document
68+
// version. Discarding is never available for the published document version. Therefore, the
69+
// parameters provided here are not configured to handle published document versions.
70+
permission: fromRelease === 'draft' ? 'discardDraft' : 'discardVersion',
6971
})
7072
const hasDiscardPermission = !isPermissionsLoading && permissions?.granted
7173

@@ -88,7 +90,7 @@ export const VersionContextMenu = memo(function VersionContextMenu(props: {
8890
{isVersion && (
8991
<IntentLink
9092
intent="release"
91-
params={{id: releaseId}}
93+
params={{id: fromRelease}}
9294
rel="noopener noreferrer"
9395
style={{textDecoration: 'none'}}
9496
disabled={disabled}

0 commit comments

Comments
 (0)