Skip to content

Commit cb01452

Browse files
authored
fix(presentation): remove explicit check for r in perspectives (#8468)
1 parent 4b54d08 commit cb01452

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

packages/sanity/src/core/perspective/useSetPerspective.tsx

+1-11
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,9 @@ export function useSetPerspective() {
99
const router = useRouter()
1010
const setPerspective = useCallback(
1111
(releaseId: 'published' | 'drafts' | ReleaseId | undefined) => {
12-
let perspectiveParam = ''
13-
14-
if (!releaseId || releaseId === 'drafts') {
15-
perspectiveParam = ''
16-
} else if (releaseId === 'published' || releaseId.startsWith('r')) {
17-
perspectiveParam = releaseId
18-
} else {
19-
throw new Error(`Invalid releaseId: ${releaseId}`)
20-
}
21-
2212
router.navigateStickyParams({
2313
excludedPerspectives: '',
24-
perspective: perspectiveParam,
14+
perspective: releaseId === 'drafts' ? '' : releaseId,
2515
})
2616
},
2717
[router],

packages/sanity/src/core/releases/util/getReleaseIdFromReleaseDocumentId.ts

-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,5 @@ export function getReleaseIdFromReleaseDocumentId(releaseDocumentId: string): Re
1515
)
1616
}
1717
const releaseId = releaseDocumentId.slice(PATH_ID_PREFIX.length)
18-
if (!releaseId.startsWith('r')) {
19-
throw new Error(`Release id was ${releaseId} but should start with "r"`)
20-
}
2118
return releaseId as ReleaseId
2219
}

packages/sanity/src/presentation/PresentationTool.tsx

+6-2
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,13 @@ export default function PresentationTool(props: {
105105
state: PresentationStateParams
106106
}
107107
const routerSearchParams = useUnique(Object.fromEntries(routerState._searchParams || []))
108-
const {perspectiveStack, selectedPerspectiveName = 'previewDrafts'} = usePerspective()
108+
const {
109+
perspectiveStack,
110+
selectedPerspectiveName = 'previewDrafts',
111+
selectedReleaseId,
112+
} = usePerspective()
109113
const perspective = (
110-
selectedPerspectiveName.startsWith('r') ? perspectiveStack : selectedPerspectiveName
114+
selectedReleaseId ? perspectiveStack : selectedPerspectiveName
111115
) as PresentationPerspective
112116

113117
const initialPreviewUrl = usePreviewUrl(

0 commit comments

Comments
 (0)