refactor(core): remove publish2 and confirm-2 (#8685)

Author: RitaDias

packages/sanity/src/core/releases/store/__tests__/createReleaseOperationsStore.test.ts

@@ -63,26 +63,9 @@ describe('createReleaseOperationsStore', () => {
     })
   })
 
-  it('should publish a release using new publish', async () => {
-    const store = createStore()
-    await store.publishRelease('_.releases.release-id', true)
-    expect(mockClient.request).toHaveBeenCalledWith({
-      uri: '/data/actions/test-dataset',
-      method: 'POST',
-      body: {
-        actions: [
-          {
-            actionType: 'sanity.action.release.publish2',
-            releaseId: 'release-id',
-          },
-        ],
-      },
-    })
-  })
-
   it('should publish a release using stable publish', async () => {
     const store = createStore()
-    await store.publishRelease('_.releases.release-id', false)
+    await store.publishRelease('_.releases.release-id')
     expect(mockClient.request).toHaveBeenCalledWith({
       uri: '/data/actions/test-dataset',
       method: 'POST',

packages/sanity/src/core/releases/store/createReleaseOperationStore.ts

@@ -18,11 +18,7 @@ interface operationsOptions {
   skipCrossDatasetValidation?: boolean
 }
 export interface ReleaseOperationsStore {
-  publishRelease: (
-    releaseId: string,
-    useUnstableAction?: boolean,
-    opts?: operationsOptions,
-  ) => Promise<void>
+  publishRelease: (releaseId: string, opts?: operationsOptions) => Promise<void>
   schedule: (releaseId: string, date: Date, opts?: operationsOptions) => Promise<void>
   //todo: reschedule: (releaseId: string, newDate: Date) => Promise<void>
   unschedule: (releaseId: string, opts?: operationsOptions) => Promise<void>
@@ -94,18 +90,12 @@ export function createReleaseOperationsStore(options: {
     )
   }
 
-  const handlePublishRelease = (
-    releaseId: string,
-    useUnstableAction?: boolean,
-    opts?: operationsOptions,
-  ) =>
+  const handlePublishRelease = (releaseId: string, opts?: operationsOptions) =>
     requestAction(
       client,
       [
         {
-          actionType: useUnstableAction
-            ? 'sanity.action.release.publish2'
-            : 'sanity.action.release.publish',
+          actionType: 'sanity.action.release.publish',
           releaseId: getReleaseIdFromReleaseDocumentId(releaseId),
         },
       ],
@@ -285,7 +275,7 @@ interface ScheduleApiAction {
 }
 
 interface PublishApiAction {
-  actionType: 'sanity.action.release.publish' | 'sanity.action.release.publish2'
+  actionType: 'sanity.action.release.publish'
   releaseId: string
 }
 

packages/sanity/src/core/releases/tool/components/releaseCTAButtons/ReleasePublishAllButton.tsx

@@ -8,7 +8,6 @@ import {ToneIcon} from '../../../../../ui-components/toneIcon/ToneIcon'
 import {Translate, useTranslation} from '../../../../i18n'
 import {usePerspective} from '../../../../perspective/usePerspective'
 import {useSetPerspective} from '../../../../perspective/useSetPerspective'
-import {supportsLocalStorage} from '../../../../util/supportsLocalStorage'
 import {PublishedRelease} from '../../../__telemetry__/releases.telemetry'
 import {releasesLocaleNamespace} from '../../../i18n'
 import {isReleaseDocument, type ReleaseDocument} from '../../../index'
@@ -34,16 +33,10 @@ export const ReleasePublishAllButton = ({
   const perspective = usePerspective()
   const setPerspective = useSetPerspective()
   const telemetry = useTelemetry()
-  const publish2 = useMemo(() => {
-    if (supportsLocalStorage) {
-      return localStorage.getItem('publish2') === 'true'
-    }
-    return false
-  }, [])
 
-  const [publishBundleStatus, setPublishBundleStatus] = useState<
-    'idle' | 'confirm' | 'confirm-2' | 'publishing'
-  >('idle')
+  const [publishBundleStatus, setPublishBundleStatus] = useState<'idle' | 'confirm' | 'publishing'>(
+    'idle',
+  )
 
   const [publishPermission, setPublishPermission] = useState<boolean>(false)
 
@@ -52,26 +45,19 @@ export const ReleasePublishAllButton = ({
 
   const isPublishButtonDisabled =
     disabled || isValidatingDocuments || hasDocumentValidationErrors || !publishPermission
-  const useUnstableAction = publishBundleStatus === 'confirm-2'
 
   useEffect(() => {
-    checkWithPermissionGuard(publishRelease, release._id, false).then((hasPermission) =>
+    checkWithPermissionGuard(publishRelease, release._id).then((hasPermission) =>
       setPublishPermission(hasPermission),
     )
-  }, [
-    checkWithPermissionGuard,
-    publishRelease,
-    release._id,
-    release.metadata.intendedPublishAt,
-    useUnstableAction,
-  ])
+  }, [checkWithPermissionGuard, publishRelease, release._id, release.metadata.intendedPublishAt])
 
   const handleConfirmPublishAll = useCallback(async () => {
     if (!release) return
 
     try {
       setPublishBundleStatus('publishing')
-      await publishRelease(release._id, useUnstableAction)
+      await publishRelease(release._id)
       telemetry.log(PublishedRelease)
       toast.push({
         closable: true,
@@ -112,7 +98,6 @@ export const ReleasePublishAllButton = ({
   }, [
     release,
     publishRelease,
-    useUnstableAction,
     telemetry,
     toast,
     t,
@@ -187,23 +172,6 @@ export const ReleasePublishAllButton = ({
 
   return (
     <>
-      {publish2 && (
-        <Button
-          tooltipProps={{
-            disabled: !isPublishButtonDisabled,
-            content: publishTooltipContent,
-            placement: 'bottom',
-          }}
-          icon={PublishIcon}
-          disabled={isPublishButtonDisabled || publishBundleStatus === 'publishing'}
-          // eslint-disable-next-line @sanity/i18n/no-attribute-string-literals
-          text={'Unstable Publish'}
-          onClick={() => setPublishBundleStatus('confirm-2')}
-          loading={publishBundleStatus === 'publishing'}
-          data-testid="publish-all-button"
-          tone="suggest"
-        />
-      )}
       <Button
         tooltipProps={{
           disabled: !isPublishButtonDisabled,

packages/sanity/src/core/releases/tool/detail/ReleaseDashboardDetails.tsx

@@ -47,7 +47,7 @@ export function ReleaseDashboardDetails({release}: {release: ReleaseDocument}) {
   useEffect(() => {
     // only run if the release is active
     if (isActive) {
-      checkWithPermissionGuard(publishRelease, release._id, false).then((hasPermission) => {
+      checkWithPermissionGuard(publishRelease, release._id).then((hasPermission) => {
         setShouldDisplayPermissionWarning(!hasPermission)
       })
 

packages/sanity/src/core/releases/tool/detail/__tests__/ReleaseDetail.test.tsx

@@ -267,7 +267,6 @@ describe('after releases have loaded', () => {
 
         expect(useReleaseOperationsMockReturn.publishRelease).toHaveBeenCalledWith(
           activeASAPRelease._id,
-          false,
         )
       })
     })