Skip to content

Commit 854a322

Browse files
RitaDiasjuice49
authored andcommitted
test(e2e): make e2e sturdier (#8348)
1 parent e5d867a commit 854a322

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

test/e2e/tests/desk/documentList.spec.ts

+13-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ function getListenEventType(request: Request): string | null | undefined {
1010
return undefined
1111
}
1212

13-
test(`navigating document creates only one listener connection`, async ({page}) => {
13+
test(`navigating document creates only one listener connection`, async ({page, browserName}) => {
14+
// For now, only test in other browsers except firefox due to flakiness in Firefox with the requests
15+
test.skip(browserName === 'firefox')
16+
17+
test.slow()
1418
await page.goto('/test/content')
1519

1620
let authorListenersCount = 0
@@ -57,7 +61,8 @@ test(`navigating document creates only one listener connection`, async ({page})
5761
const keyValueRequest = page.waitForResponse((response) => response.url().includes('keyvalue'))
5862

5963
await page.getByTestId('pane-item-Author').click({force: true})
60-
await page.waitForSelector('#author-author-0')
64+
await expect(page.locator('#author-author-0')).toBeVisible()
65+
await expect(page.getByTestId('document-list-pane')).toBeVisible()
6166
await authorRequest
6267
expect(bookListenersCount).toBe(0)
6368
expect(authorListenersCount).toBe(1)
@@ -68,19 +73,22 @@ test(`navigating document creates only one listener connection`, async ({page})
6873
await keyValueRequest
6974

7075
await page.getByTestId('pane-item-Book').click({force: true})
71-
await page.waitForSelector('#book-book-0')
76+
await expect(page.locator('#book-book-0')).toBeVisible()
77+
await expect(page.getByTestId('document-list-pane')).toBeVisible()
7278
expect(authorListenersCount).toBe(0)
7379
expect(bookListenersCount).toBe(1)
7480
await bookRequest
7581

7682
await page.getByTestId('pane-item-Author').click({force: true})
77-
await page.waitForSelector('#author-author-0')
83+
await expect(page.locator('#author-author-0')).toBeVisible()
84+
await expect(page.getByTestId('document-list-pane')).toBeVisible()
7885
expect(bookListenersCount).toBe(0)
7986
expect(authorListenersCount).toBe(1)
8087
await authorRequest
8188

8289
await page.getByTestId('pane-item-Book').click({force: true})
83-
await page.waitForSelector('#book-book-0')
90+
await expect(page.locator('#book-book-0')).toBeVisible()
91+
await expect(page.getByTestId('document-list-pane')).toBeVisible()
8492
expect(authorListenersCount).toBe(0)
8593
expect(bookListenersCount).toBe(1)
8694
await bookRequest

test/e2e/tests/inputs/reference.spec.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ withDefaultClient((context) => {
3434
const paneFooter = page.getByTestId('pane-footer')
3535
const publishButton = page.getByTestId('action-publish')
3636
const authorListbox = page.locator('#author-listbox')
37+
const popover = page.locator("[data-ui='Popover']")
3738

3839
// Open the Author reference input.
3940
await referenceInput.getByLabel('Open').click()
40-
await expect(authorListbox).toBeAttached()
41+
await expect(popover).toBeVisible()
4142
await expect(authorListbox).toBeVisible()
4243

4344
// Select the first document in the list.
@@ -52,7 +53,7 @@ withDefaultClient((context) => {
5253
await page.locator('#author-menuButton').click()
5354
await page.getByRole('menuitem').getByText('Replace').click()
5455
await referenceInput.getByLabel('Open').click()
55-
await expect(authorListbox).toBeAttached()
56+
await expect(popover).toBeVisible()
5657
await expect(authorListbox).toBeVisible()
5758

5859
// Select the next document in the list.

0 commit comments

Comments
 (0)