Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Use the new Mux Player #25

Open
stipsan opened this issue Aug 8, 2022 · 3 comments
Open

Use the new Mux Player #25

stipsan opened this issue Aug 8, 2022 · 3 comments

Comments

@stipsan
Copy link
Member

stipsan commented Aug 8, 2022

Mux have released a new player.

It implements Mux Data and is overall a really good player.

Relates to:

@dylanjha
Copy link

dylanjha commented Aug 8, 2022

@stipsan 🙌🏼

Do you think it might make sense to deprecate the sanity-mux-player and simply point folks directly to Mux Player?

If sanity-mux-player is just a wrapper around Mux Player then it's not really doing a whole lot and it would be one more package to maintain and keep up to date every time there is a new Mux Player release. Which is ~every week right now.

Just a thought. Thanks for opening the issue, I was wanting to follow up with y'all about this 🙌🏼

@stipsan
Copy link
Member Author

stipsan commented Aug 8, 2022

@dylanjha that would be brilliant ☺️ does the mux player give feedback on statuses such as if it's in preparing right after it's been uploaded?

@dylanjha
Copy link

dylanjha commented Aug 9, 2022

Yep, Mux Player will catch common error states, log it to the dev console and link to more detailed error page.

If an asset is still preparing it will link to this 412 error: https://github.com/muxinc/elements/blob/main/errors/412-not-playable.md

(With Mux Player, these common error states also show up in Mux Data)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants