Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling Product Page Variant Select Quantities #177

Open
chrismekim opened this issue May 7, 2021 · 0 comments
Open

Improve handling Product Page Variant Select Quantities #177

chrismekim opened this issue May 7, 2021 · 0 comments
Assignees

Comments

@chrismekim
Copy link
Contributor

image.png

In add-to-cart-container.liquid, we have a quantity select dropdown and a variant select dropdown.

For lack of time, the quantity select dropdown was implemented to show options 1 - 10, regardless of the selected product variant's available inventory. This was discussed in this PR.

The problem:

  • A user can try to add more items than available. They won't be able to successfully do this, but there is no feedback that this action failed.

Possible solutions:

  • Have eventListeners to listen when the "selected" variant changes, and update the quantity based on the selected product variant's inventory
  • Show a notification to let the user know they are not able to add the quantity selected.
@chrismekim chrismekim changed the title Handle Product Page Variant Select Quantities Improve handling Product Page Variant Select Quantities May 7, 2021
@chrismekim chrismekim self-assigned this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant