Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Webpack(er) for replacing jquery-datatables-rails #3920

Open
jrgriffiniii opened this issue Aug 23, 2019 · 1 comment
Open

Explore Webpack(er) for replacing jquery-datatables-rails #3920

jrgriffiniii opened this issue Aug 23, 2019 · 1 comment

Comments

@jrgriffiniii
Copy link
Contributor

The jquery-datatables-rails Gem currently specifies sass-rails as a dependency, and rails new for 5.1.x/5.2.x releases pins to the latest 5.1.x release of this Gem:

workspace1 % rails _5.2.3_ new my_app
      create
      create  README.md
      create  Rakefile

...

workspace1 % cd my_app
my_app HEAD % bundle list | grep sass
  * sass (3.7.4)
  * sass-listen (4.0.0)
  * sass-rails (5.1.0)

Given that there is already an existing issue within the generation of Hyrax for this Gem (please see https://github.com/samvera/hyrax/blob/master/lib/generators/hyrax/install_generator.rb#L152 and rweng/jquery-datatables-rails#225), perhaps shifting the integration of Datatables to Webpack (using https://datatables.net/download/npm, https://webpack.js.org/configuration/externals/, and https://github.com/rails/webpacker) could be explored in order to deprecate this Gem dependency. Please see #3919 for a bit more context.

@ghost
Copy link

ghost commented Aug 27, 2019

Is it insane to consider use of webpacker for more of the asset pipeline or just for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant