Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube sound does not stop. Browser pool not working as expected. #67

Open
nykez opened this issue Oct 2, 2024 · 0 comments
Open

Youtube sound does not stop. Browser pool not working as expected. #67

nykez opened this issue Oct 2, 2024 · 0 comments

Comments

@nykez
Copy link

nykez commented Oct 2, 2024

YouTube video sounds keep playing even after the media-player was removed. I suspect it has something to do with how the browserpool is recycling. Possible a Youtube or gmod update has caused this.

I will look into this in my spare time but a temp fix is to make the YouTube service destroy the panel instead of recycling:

browserpool.release( self.Browser, true)
@Nexeonenn Nexeonenn mentioned this issue Oct 8, 2024
Open
CattoGamer added a commit to PurrCoding/gm-mediaplayer that referenced this issue Dec 25, 2024
@CattoGamer
Correction of non-closing YouTube Video
1a48161 
PR Port of samuelmaddock#68 for issue samuelmaddock#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nykez