bigdecimal no longer part of the default gems warning

[bgsmase]

I have started getting warnings such as below when executing timetrap commands using version 1.15.2:

lib/ruby/gems/3.3.0/gems/sequel-5.30.0/lib/sequel.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add bigdecimal to your Gemfile or gemspec to silence this warning.

I see from looking at the sequel code that this was fixed there in jeremyevans/sequel@c6a0178 and so should be in versions from 5.72.0 and later of sequel. Timetrap currently depends on version sequel 5.30.0 so can this be updated.

[SebastianBalle]

@dechimp Could you help resolve this? I see you made the last commit to the project. I have similar issue when installing timetrap from nixpgs

[dechimp]

I might need some help with this, because I am new with maintaining packages.

I noticed just now that I had not run git tag --push, so 1.15.4 as of now should now be the latest tag. But on rubygems, the latest version of timetrap has been 1.15.4 for some time (https://rubygems.org/gems/timetrap/versions/1.15.4).

However I see you are installing it from nix. To update timetrap on nix, does someone need to make a PR and change the Gemfile.lock (nixpkgs). Are there nix maintainers that do this for this package? If you know, please let me know.

Otherwise I would recommend just installing directly from rubygems gem install timetrap.

[jerith666]

Hmm, I fixed it in my fork of nixpkgs like so: jerith666/nixpkgs@61bcbed. I meant to open a PR to upstream that, but it looks like I never did. And maybe that's good, because it sounds like you're saying that isn't the right fix! :)

Nixpkgs is currently on 1.15.2. I don't see anything in the changes from that version to 1.15.4 that would address this problem. Am I right in understanding that the fix would be to bump the version here?

timetrap/timetrap.gemspec

Line 28 in 95fcf74

spec.add_dependency "sequel", "~> 5.30.0"

If such a fix is made here and a new version released, I can take care of updating nixpkgs to use that new version.

[SebastianBalle]

@jerith666 Unfortunately I am not that familiar with Ruby so cannot confirm but my initial assumption it looks like this would solve the problem but can't confirm.

I cannot install using gem install timetrap my entire setup is controlled by Nix hence the directories are owned by Nix.

[dechimp]

@jerith666 Yes I believe the sequel version bump is the fix. Thanks.

[jerith666]

I've opened #222 to bump sequel, but I'm not able to test it because I can't get bundix to pick up the change in a way that builds cleanly. :(

[trliner]

Worked for me on MacOS, Ruby 3.1.6. Thanks!