Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@values with commas and quotes in them? #22

Closed
max opened this issue Apr 19, 2016 · 5 comments
Closed

@values with commas and quotes in them? #22

max opened this issue Apr 19, 2016 · 5 comments

Comments

@max
Copy link

max commented Apr 19, 2016

Is it possible to have a @value for a font-family?

@value --font-family: "Helvetica Neue", Arial, Geneva, sans-serif;

.foobar {
  font-family: --font-family;
}

/* yields */

.foobar {
  font-family: "Helvetica Neue";
}
@dfreeman
Copy link
Member

😭 I'd forgotten about this. css-modules/postcss-modules-values#23

@dfreeman
Copy link
Member

If it comes to it, I may switch to a fork of postcss-modules-values until that PR moves forward, because this is a pretty obnoxious bug.

@buschtoens
Copy link
Contributor

The upstream fix got merged! :)

@dfreeman
Copy link
Member

I saw! :)
Unfortunately the loader itself is locked to specific patch releases of its constituent plugins, so this won't just start working for free.

I'll aim to cut a release with this and (hopefully) #40 in the next couple of days.

@dfreeman
Copy link
Member

Just released v0.4.3 with a fix for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants