Skip unnecessary type-id check

Author: Veykril

Diff for: src/accumulator.rs

@@ -100,7 +100,7 @@ impl<A: Accumulator> Ingredient for IngredientImpl<A> {
         self.index
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         _db: &dyn Database,
         _input: Id,

Diff for: src/function.rs

@@ -218,7 +218,7 @@ where
         self.index
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         db: &dyn Database,
         input: Id,

Diff for: src/ingredient.rs

@@ -51,7 +51,11 @@ pub trait Ingredient: Any + std::fmt::Debug + Send + Sync {
     fn debug_name(&self) -> &'static str;
 
     /// Has the value for `input` in this ingredient changed after `revision`?
-    fn maybe_changed_after<'db>(
+    ///
+    /// # Safety
+    ///
+    /// The passed in database needs to be the same one that the ingredient was created with.
+    unsafe fn maybe_changed_after<'db>(
         &'db self,
         db: &'db dyn Database,
         input: Id,

Diff for: src/input.rs

@@ -215,7 +215,7 @@ impl<C: Configuration> Ingredient for IngredientImpl<C> {
         self.ingredient_index
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         _db: &dyn Database,
         _input: Id,

Diff for: src/input/input_field.rs

@@ -49,7 +49,7 @@ where
         CycleRecoveryStrategy::Panic
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         db: &dyn Database,
         input: Id,

Diff for: src/interned.rs

@@ -282,7 +282,7 @@ where
         self.ingredient_index
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         _db: &dyn Database,
         _input: Id,

Diff for: src/key.rs

@@ -100,10 +100,12 @@ impl InputDependencyIndex {
         last_verified_at: crate::Revision,
     ) -> MaybeChangedAfter {
         match self.key_index {
-            Some(key_index) => db
-                .zalsa()
-                .lookup_ingredient(self.ingredient_index)
-                .maybe_changed_after(db, key_index, last_verified_at),
+            // SAFETY: The `db` belongs to the ingredient
+            Some(key_index) => unsafe {
+                db.zalsa()
+                    .lookup_ingredient(self.ingredient_index)
+                    .maybe_changed_after(db, key_index, last_verified_at)
+            },
             // Data in tables themselves remain valid until the table as a whole is reset.
             None => MaybeChangedAfter::No(InputAccumulatedValues::Empty),
         }

Diff for: src/tracked_struct.rs

@@ -735,7 +735,7 @@ where
         self.ingredient_index
     }
 
-    fn maybe_changed_after(
+    unsafe fn maybe_changed_after(
         &self,
         db: &dyn Database,
         input: Id,

Diff for: src/tracked_struct/tracked_field.rs

@@ -55,7 +55,7 @@ where
         crate::cycle::CycleRecoveryStrategy::Panic
     }
 
-    fn maybe_changed_after<'db>(
+    unsafe fn maybe_changed_after<'db>(
         &'db self,
         db: &'db dyn Database,
         input: Id,