Merge branch 'update'

Author: lkrms

.phive/phars.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="lkrms/pretty-php" version="^0.4.48" installed="0.4.91" location="./tools/pretty-php" copy="true"/>
-  <phar name="php-cs-fixer" version="^3.46.0" installed="3.69.1" location="./tools/php-cs-fixer" copy="true"/>
+  <phar name="lkrms/pretty-php" version="^0.4.48" installed="0.4.92" location="./tools/pretty-php" copy="true"/>
+  <phar name="php-cs-fixer" version="^3.46.0" installed="3.74.0" location="./tools/php-cs-fixer" copy="true"/>
   <phar name="salient-labs/changelog" version="^1.0.5" installed="1.0.8" location="./tools/changelog" copy="true"/>
   <phar name="composer-require-checker" version="^4.16.1" installed="4.16.1" location="./tools/composer-require-checker" copy="true"/>
 </phive>

composer.lock

@@ -740,8 +740,9 @@ final public function propertyActionIsAllowed(string $property, string $action):
                     $property,
                     $this->getWritableProperties()
                 );
-        }
 
-        return false;
+            default:
+                return false;
+        }
     }
 }

src/Toolkit/Core/Legacy/IntrospectionClass.php

@@ -32,7 +32,7 @@ class CurlerHarRecorder
     protected ?string $Uri;
     protected bool $IsRecording = false;
     /** @var int[] */
-    protected array $ListenerIds;
+    protected array $ListenerIds = [];
     protected ?RequestInterface $LastRequest = null;
     protected float $LastRequestTime;
     protected int $EntryCount = 0;
@@ -146,7 +146,7 @@ public function stop(): void
         foreach ($this->ListenerIds as $id) {
             Event::removeListener($id);
         }
-        unset($this->ListenerIds);
+        $this->ListenerIds = [];
 
         $this->IsRecording = false;
     }
@@ -172,7 +172,6 @@ protected function handleCurlResponse(CurlResponseEvent $event): void
         $requestTime = $this->LastRequestTime;
 
         $this->LastRequest = null;
-        unset($this->LastRequestTime);
 
         $handle = $event->getCurlHandle();
 

src/Toolkit/Curler/CurlerHarRecorder.php

@@ -28,10 +28,10 @@ class HttpServer implements Immutable
     protected string $Host;
     protected int $Port;
     protected int $Timeout;
-    protected string $ProxyHost;
-    protected int $ProxyPort;
-    protected bool $ProxyTls;
-    protected string $ProxyBasePath;
+    private string $ProxyHost;
+    private int $ProxyPort;
+    private bool $ProxyTls;
+    private string $ProxyBasePath;
     private string $Socket;
     /** @var resource|null */
     private $Server;

src/Toolkit/Http/HttpServer.php

@@ -208,6 +208,7 @@ public static function fromExtractor(
                 if ($filter && !$filter($memberData, $type)) {
                     $memberData->Hide = true;
                 }
+                // @phpstan-ignore assign.propertyType, assign.propertyType, assign.propertyType
                 $data->$property[$name] = $memberData;
             }
         }
@@ -315,6 +316,7 @@ public static function fromReflection(
                 if ($filter && !$filter($memberData, $type)) {
                     $memberData->Hide = true;
                 }
+                // @phpstan-ignore assign.propertyType, assign.propertyType, assign.propertyType
                 $data->$property[$member->getName()] = $memberData;
             }
         }
@@ -446,6 +448,7 @@ private function getInheritedMemberData($data, ClassDataFactory $factory)
             }
         }
 
+        // @phpstan-ignore return.type
         return $data;
     }
 

src/Toolkit/Sli/Internal/Data/ClassData.php

@@ -504,6 +504,7 @@ final protected function getPipelineToBackend(): PipelineInterface
         /** @var PipelineInterface<TEntity,mixed[],SyncPipelineArgument> */
         $pipeline = $pipeline->through(
             fn($payload, Closure $next) =>
+                // @phpstan-ignore instanceof.alwaysFalse
                 $payload instanceof SyncEntityInterface
                     ? $next($payload->toArray())
                     : $next($payload)
@@ -539,6 +540,7 @@ final protected function getPipelineFromBackend(): PipelineInterface
         $ctx = null;
 
         return $pipeline
+            // @phpstan-ignore argument.type
             ->then(function (
                 array $data,
                 PipelineInterface $pipeline,

src/Toolkit/Sync/AbstractSyncDefinition.php

@@ -535,14 +535,15 @@ protected function getClosure(int $operation): ?Closure
                         ->unlessIf(fn($entity) => $entity === null)
                         ->start();
                 };
-        }
 
-        // @codeCoverageIgnoreStart
-        throw new LogicException(sprintf(
-            'Invalid SyncOperation: %d',
-            $operation,
-        ));
-        // @codeCoverageIgnoreEnd
+            default:
+                // @codeCoverageIgnoreStart
+                throw new LogicException(sprintf(
+                    'Invalid SyncOperation: %d',
+                    $operation,
+                ));
+                // @codeCoverageIgnoreEnd
+        }
     }
 
     /**
@@ -559,7 +560,6 @@ private function getHttpOperationClosure(int $operation): Closure
             && Env::getDryRun()
         ) {
             /** @var Closure(CurlerInterface, mixed[]|null, mixed[]|null=): mixed[] */
-            // @phpstan-ignore varTag.nativeType
             return fn(CurlerInterface $curler, ?array $query, ?array $payload = null) =>
                 $payload ?? [];
         }