Merge branch 'review-application'

Author: lkrms

docs/Console.md

@@ -43,7 +43,7 @@ target, e.g. by calling [registerTarget()][registerTarget], before any other
 > `STDOUT` and `STDERR` targets and prevents creation of the default output log.
 > To create a log file that persists between reboots (in your project's
 > `var/log` directory by default), call the app container's
-> [logConsoleMessages()][logConsoleMessages] method.
+> [logOutput()][logOutput] method.
 
 ### Output methods
 
@@ -81,7 +81,7 @@ The following Markdown-like syntax is supported in [Console][Console] messages:
 [CliApplication]: https://lkrms.github.io/php-util/Lkrms.Cli.CliApplication.html
 [Console]: https://lkrms.github.io/php-util/Lkrms.Facade.Console.html
 [ConsoleWriter]: https://lkrms.github.io/php-util/Lkrms.Console.ConsoleWriter.html
-[logConsoleMessages]: https://lkrms.github.io/php-util/Lkrms.Container.Application.html#_logConsoleMessages
+[logOutput]: https://lkrms.github.io/php-util/Lkrms.Container.Application.html#_logOutput
 [registerStdioTargets]: https://lkrms.github.io/php-util/Lkrms.Console.ConsoleWriter.html#_registerStdioTargets
 [registerTarget]: https://lkrms.github.io/php-util/Lkrms.Console.ConsoleWriter.html#_registerTarget
 

lib/lk-util/bootstrap.php

@@ -14,8 +14,8 @@
 $loader->addPsr4('Lkrms\\LkUtil\\', __DIR__);
 
 (new CliApplication())
-    ->loadCacheIfExists()
-    ->logConsoleMessages()
+    ->resumeCache()
+    ->logOutput()
     ->command(['generate', 'builder'], GenerateBuilder::class)
     ->command(['generate', 'facade'], GenerateFacade::class)
     ->command(['generate', 'sync', 'entity'], GenerateSyncEntity::class)

phpstan-baseline.neon

@@ -55,6 +55,31 @@ parameters:
 			count: 1
 			path: src/Concept/Facade.php
 
+		-
+			message: "#^Property Lkrms\\\\Container\\\\Application\\:\\:\\$CachePath is never written, only read\\.$#"
+			count: 1
+			path: src/Container/Application.php
+
+		-
+			message: "#^Property Lkrms\\\\Container\\\\Application\\:\\:\\$ConfigPath is never written, only read\\.$#"
+			count: 1
+			path: src/Container/Application.php
+
+		-
+			message: "#^Property Lkrms\\\\Container\\\\Application\\:\\:\\$DataPath is never written, only read\\.$#"
+			count: 1
+			path: src/Container/Application.php
+
+		-
+			message: "#^Property Lkrms\\\\Container\\\\Application\\:\\:\\$LogPath is never written, only read\\.$#"
+			count: 1
+			path: src/Container/Application.php
+
+		-
+			message: "#^Property Lkrms\\\\Container\\\\Application\\:\\:\\$TempPath is never written, only read\\.$#"
+			count: 1
+			path: src/Container/Application.php
+
 		-
 			message: "#^Method Lkrms\\\\Contract\\\\IPipe\\:\\:handle\\(\\) has parameter \\$pipeline with generic interface Lkrms\\\\Contract\\\\IPipeline but does not specify its types\\: TInput, TOutput, TArgument$#"
 			count: 1

scripts/generate.php

@@ -77,7 +77,7 @@
 $args = [
     '--force',
     '--no-meta',
-    ...array_slice($argv, 1),
+    ...array_slice($_SERVER['argv'], 1),
 ];
 
 $status = 0;

src/Cli/CliApplication.php

@@ -46,9 +46,12 @@ class CliApplication extends Application implements ICliApplication
      */
     private $HelpStyle;
 
-    public function __construct(string $basePath = null, int $envFlags = EnvFlag::ALL)
-    {
-        parent::__construct($basePath, $envFlags);
+    public function __construct(
+        ?string $basePath = null,
+        ?string $appName = null,
+        int $envFlags = EnvFlag::ALL
+    ) {
+        parent::__construct($basePath, $appName, $envFlags);
 
         Assert::sapiIsCli();
         Assert::argvIsRegistered();