Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible bug]: Extension's favicon isn't visible in chrome bar #12

Open
zurda opened this issue Oct 11, 2020 · 5 comments
Open

[Possible bug]: Extension's favicon isn't visible in chrome bar #12

zurda opened this issue Oct 11, 2020 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@zurda
Copy link
Contributor

zurda commented Oct 11, 2020

What's happening

When Chrome is using the default settings (light theme), the favicon for the extension isn't visible.

Steps to reproduce:

  • Pin the extension to the chrome bar,
  • Set you chrome theme to default settings

This is how it looks for me - only visible on hover

favicon

Not sure if anyone else is experiencing this, but I thought it's worth reporting. Please feel free to close if this is just an error on my end.

Chrome: Version 86.0.4240.75 (Official Build) (x86_64)

@zurda zurda changed the title [Possible bug]: Bug isn't visible in chrome bar [Possible bug]: Extension's favicon isn't visible in chrome bar Oct 11, 2020
@saifabusaleh saifabusaleh added bug Something isn't working Hacktoberfest targe_release_1.3 will be released in version 1.3 labels Oct 12, 2020
@saifabusaleh
Copy link
Owner

@zurda You are right, thanks for reporting 👍

@aaronleopold
Copy link

I can take a look at this if you'd like, I've never looked at an extension project before so should be interesting 🙂

@saifabusaleh
Copy link
Owner

Hi @aaronleopold,

Sure go ahead, if you need any assistance I am here :)

@aaronleopold
Copy link

aaronleopold commented Oct 13, 2020

Okay, so I did some research and apparently this is a "feature." Google documentation for making extensions states to "avoid monochrome themes like Google uses" and to make sure you "create icons that are properly visible" on a variety of themes. There is a very buggy work around based on matching the color scheme preference of the user, however if they were to change themes it does not seem to update properly.

@saifabusaleh
Copy link
Owner

Okay, so I did some research and apparently this is a "feature." Google documentation for making extensions states to "avoid monochrome themes like Google uses" and to make sure you "create icons that are properly visible" on a variety of themes. There is a very buggy work around based on matching the color scheme preference of the user, however if they were to change themes it does not seem to update properly.

I see, maybe you can check if you can update the current icon color to color that can be properly visible on a variety of themes?
Thanks

@saifabusaleh saifabusaleh added the good first issue Good for newcomers label Oct 17, 2020
@saifabusaleh saifabusaleh removed the targe_release_1.3 will be released in version 1.3 label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants