bugfix: recent sage kernel workaround can cause crash

williamstein · williamstein · commit 0a94eedb62ee · 2024-10-25T13:46:55.000Z
diff --git a/src/packages/frontend/jupyter/output-messages/mime-types/data.tsx b/src/packages/frontend/jupyter/output-messages/mime-types/data.tsx
@@ -77,7 +77,8 @@ function getUntrustedType(kernelspec: KernelSpec | undefined, types: string[]) {
 }
 
 function getTypeToRender(kernelspec, types: string[]): string {
-  if (kernelspec.language?.startsWith("sage")) {
+  if (kernelspec?.language?.startsWith("sage")) {
+    // kernelspec might not be defined initially.
     // special case because sage's text/html is horrible.
     if (
       (types.includes("text/html") || types.includes("iframe")) &&

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ function getUntrustedType(kernelspec: KernelSpec \| undefined, types: string[]) {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`function getTypeToRender(kernelspec, types: string[]): string {`
`80`		`- if (kernelspec.language?.startsWith("sage")) {`
	`80`	`+ if (kernelspec?.language?.startsWith("sage")) {`
	`81`	`+ // kernelspec might not be defined initially.`
`81`	`82`	`// special case because sage's text/html is horrible.`
`82`	`83`	`if (`
`83`	`84`	`(types.includes("text/html") \|\| types.includes("iframe")) &&`