Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone closed_at date is wrong #136

Open
mkoeppe opened this issue Jan 16, 2023 · 7 comments
Open

Milestone closed_at date is wrong #136

mkoeppe opened this issue Jan 16, 2023 · 7 comments
Labels
question Further information is requested

Comments

@mkoeppe
Copy link

mkoeppe commented Jan 16, 2023

as seen in https://34.105.185.241/sagemath/sage-all-2023-01-14-004/milestones?state=closed

@mkoeppe mkoeppe reopened this Jan 16, 2023
@mkoeppe mkoeppe added this to the Switchover to GitHub milestone Jan 16, 2023
@mkoeppe mkoeppe added the question Further information is requested label Jan 16, 2023
@mkoeppe
Copy link
Author

mkoeppe commented Jan 16, 2023

I now set both closed_at and updated_at, but after the import both show the time of import.

This seems to be a bug of the importer -- question for the GH migration team.

@kwankyu
Copy link

kwankyu commented Jan 23, 2023

This is important. Was the question asked to the GH team?

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

So this is not fixed even in the import to GitHub.com.

@mkoeppe
Copy link
Author

mkoeppe commented Feb 4, 2023

Yes. Out GH contacts indicate that it cannot be fixed.

After the import, I suppose we can edit the milestone description to include the correct closing date.

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

The correct closing date is defined by some event in the repo or is a new information that we should fetch from trac?

@mkoeppe
Copy link
Author

mkoeppe commented Feb 4, 2023

We have it in the migration archive, in these files:

milestones_000000.json.txt
milestones_000001.json.txt

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

It's strange that GH cannot fix the obvious bug in their importer.

Hopefully we could edit the dates in an automatic way later.

Thanks.

@mkoeppe mkoeppe removed this from the Switchover to GitHub milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants