Skip to content

Commit 8e5ca6a

Browse files
committed
Add back is_approximate as deprecated property
1 parent 012dd61 commit 8e5ca6a

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

src/sage/schemes/elliptic_curves/period_lattice.py

+32
Original file line numberDiff line numberDiff line change
@@ -1167,6 +1167,38 @@ def curve(self):
11671167
"""
11681168
return self.E
11691169

1170+
@property
1171+
def is_approximate(self):
1172+
"""
1173+
``self.is_approximate`` is deprecated, use ``not self.curve().is_exact()`` instead.
1174+
1175+
TESTS::
1176+
1177+
sage: E = EllipticCurve(ComplexField(100), [I, 3*I+4])
1178+
sage: L = E.period_lattice()
1179+
sage: L.is_approximate
1180+
doctest:...: DeprecationWarning: The attribute is_approximate for period lattice is deprecated,
1181+
use self.curve().is_exact() instead.
1182+
See https://github.com/sagemath/sage/issues/39212 for details.
1183+
True
1184+
sage: L.curve() is E
1185+
True
1186+
sage: E.is_exact()
1187+
False
1188+
sage: E = EllipticCurve(QQ, [0, 2])
1189+
sage: L = E.period_lattice()
1190+
sage: L.is_approximate
1191+
False
1192+
sage: L.curve() is E
1193+
True
1194+
sage: E.is_exact()
1195+
True
1196+
"""
1197+
from sage.misc.superseded import deprecation
1198+
deprecation(39212, "The attribute is_approximate for period lattice is "
1199+
"deprecated, use self.curve().is_exact() instead.")
1200+
return not self._is_exact
1201+
11701202
def ei(self):
11711203
r"""
11721204
Return the x-coordinates of the 2-division points of the elliptic curve associated

0 commit comments

Comments
 (0)