Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Numpy >= 2 #57

Open
pablormier opened this issue Dec 2, 2024 · 5 comments
Open

Incompatibility with Numpy >= 2 #57

pablormier opened this issue Dec 2, 2024 · 5 comments
Assignees

Comments

@pablormier
Copy link
Member

pablormier commented Dec 2, 2024

Omnipath fails using numpy >= 2. I get the following error when importing:

ckages/numpy/__init__.py", line 410, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'NAN'. Did you mean: 'nan'?

Comes from:

  from omnipath._misc import dtypes
  File "/miniforge3/envs/corneto/lib/python3.12/site-packages/omnipath/_misc/dtypes.py", line 11, in <module>
    NA = frozenset(("na", "NA", "NaN", "none", "None", None, pd.NA, pd.NaT, np.NAN, np.nan))
@jhaberbe
Copy link

Same, I just removed np.NAN.

@deeenes deeenes self-assigned this Dec 16, 2024
@deeenes
Copy link
Member

deeenes commented Dec 16, 2024

This has been fixed already in June (2dfecfd), we should do a version bump and push to PyPI (as also requested in #56). I'll do that soon.

@JureZmrzlikar
Copy link

JureZmrzlikar commented Jan 30, 2025

This has been fixed already in June (2dfecfd), we should do a version bump and push to PyPI (as also requested in #56). I'll do that soon.

Ping @deeenes . :-) I would be very happy if you could release this to Pypi... Or at least estimate until when this will be done.

@PauBadiaM
Copy link
Member

@deeenes same for me! 🙏

@CowanCS1
Copy link

I also just hit this. Easy enough to fix, but for reproducibility downstream it would be nice to have that version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants