-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Fonts nit #227
Comments
I think you could've made the issue a little clearer by describe the actual problem (like a background and suggesting the alternative.) instead of just throwing a link here and said 'it doesn't work well'. GoogleFonts got recommended here simply because it is very easy to get things up and running. And giving out a nice example to work with quickly. if you have an alternative solution, You should purpose one up so the author can considering your request. |
Sorry, I assumed Mike knows exactly what's going on here, this has been a pretty well known issue with Google Fonts on X, so I assumed everyone knew. Background
However, I propose that we shouldn't ignore the fact that this isn't as simple as it looks, or remove it |
Hi, @dickermoshe and @famasf1 thanks for taking an interest in the wondrous world of GoogleFonts and TextTheme 😄 I'm well aware of the challenges many face with setting up fonts using Where I show how to do it, to set it up so that you do get the correct weights as defined to actually be used and shown up in your Another interesting discussion about this can be found in this X/Twitter post and its many branches: https://x.com/luke_pighetti/status/1759721848353288601 Where I give a few similar examples on what to do to make different weights work correctly. Some links to that: worth nothing is also, if you font does not contain the weights, you always only get poor approximations for those weights. All fixed fonts do not contain all weights. You can find some interesting discussions in the thread here: https://x.com/luke_pighetti/status/1759912133339259283 and here: https://x.com/RydMike/status/1759920719121547306 While this is not something that is really a FlexColorScheme issue, or even a Flutter After I have released version 8.0.0 I will be doing som overhaul of the docs. I will then add info about this this as well. I can then also include a URL link to the info in the copy/paste code about GoogleFonts usage. Until then, I'm going to keep this issue open as reminder to improve the docs about this topic. This is by the way also a little annoying bug in GoogleFonts and using its text theme feature: material-foundation/flutter-packages#401 And this one is about wrong color of FlexColorScheme fixes and works around both those two issue. The |
As we know the Google Fonts package doent work well
material-foundation/flutter-packages#35
Could this either link to the workaround or be removed
The text was updated successfully, but these errors were encountered: