Skip to content

Commit ef91db1

Browse files
committedMar 5, 2012
Use block statements in loops rather that expressions to improve readability and to make it easier to debug via jslint. It minifies exactly the same.
1 parent 74a386c commit ef91db1

File tree

1 file changed

+30
-14
lines changed

1 file changed

+30
-14
lines changed
 

‎response.js

+30-14
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @version 0.4.1
77
* @requires jQuery 1.7+ or Zepto 0.8+
88
*/
9-
9+
1010
;window.Response = (function(namespace, $, window, doc, undef) {
1111

1212
// If you want to alias Response to a shorter name in your scripts you can do:
@@ -158,7 +158,9 @@
158158
, i = -1
159159
, len = arr.length;
160160
while ( i++ < len ) {
161-
i in arr && (r[i] = callback.call(scope, arr[i]));
161+
if (i in arr) {
162+
r[i] = callback.call(scope, arr[i]);
163+
}
162164
}
163165
return r;
164166
}
@@ -178,7 +180,9 @@
178180
var i
179181
, len = arr.length;
180182
for (i = 0; i < len; i++) {
181-
i in arr && callback(arr[i], i, arr);
183+
if (i in arr) {
184+
callback(arr[i], i, arr);
185+
}
182186
}
183187
return arr; // chainable
184188
}
@@ -191,7 +195,9 @@
191195
prefix = prefix || '';
192196
suffix = suffix || '';
193197
while ( i && i-- ) {
194-
i in arr && (r[i] = prefix + arr[i] + suffix);
198+
if (i in arr) {
199+
r[i] = prefix + arr[i] + suffix;
200+
}
195201
}
196202
return r;
197203
}
@@ -224,12 +230,16 @@
224230
if (callback) {
225231
invert = !!invert; // ensure boolean
226232
while ( i++ < len ) {// Filter out values that don't pass callback:
227-
invert === !callback(arr[i], i) && ret.push(arr[i]);
233+
if (invert === !callback(arr[i], i)) {
234+
ret.push(arr[i]);
235+
}
228236
}
229237
}
230238
else {
231239
while ( i++ < len ) {// Filter out all falsey values:
232-
arr[i] && ret.push(arr[i]);
240+
if (arr[i]) {
241+
ret.push(arr[i]);
242+
}
233243
}
234244
}
235245
return ret;
@@ -412,7 +422,9 @@
412422
if ( 'string' === typeof keys ) {
413423
var $elems = selectOnce(this);
414424
forEach(ssvToArr(keys), function(key) {
415-
key && $elems.removeAttr(datatize(key));
425+
if (key) {
426+
$elems.removeAttr(datatize(key));
427+
}
416428
});
417429
}
418430
return this;
@@ -524,19 +536,19 @@
524536
return overflow('Height');
525537
}
526538

527-
// Response.scrollX() and Response.scrollY()
539+
// Response.scrollX() and Response.scrollY()
528540
// Cross-browser versions of window.scrollX and window.scrollY
529541
// Compatibiliy notes @link developer.mozilla.org/en/DOM/window.scrollY
530542
// Performance tests @link jsperf.com/scrollx-cross-browser-compatible
531543
// Using native here b/c Zepto doesn't support .scrollLeft() /scrollTop()
532544
// In jQuery you can do $(window).scrollLeft() and $(window).scrollTop()
533545

534546
, scrollX = function(){
535-
return window.pageXOffset || docElem.scrollLeft;
536-
}
547+
return window.pageXOffset || docElem.scrollLeft;
548+
}
537549
, scrollY = function(){
538-
return window.pageYOffset || docElem.scrollTop;
539-
}
550+
return window.pageYOffset || docElem.scrollTop;
551+
}
540552

541553
/**
542554
* area methods inX/inY/inViewport
@@ -793,7 +805,9 @@
793805
var r = []
794806
, i = keys.length;
795807
while ( i && i-- ) {
796-
i in keys && (r[i] = '[' + datatize(keys[i].replace(regexSelectorOps, '\\$1')) + ']');
808+
if (i in keys) {
809+
r[i] = '[' + datatize(keys[i].replace(regexSelectorOps, '\\$1')) + ']';
810+
}
797811
}
798812
return r.join();
799813
}
@@ -1133,7 +1147,9 @@
11331147

11341148
function scrollHandler() {
11351149
forEach(elemset.$, function(el, i) {
1136-
inViewport(elemset[i].$, verge) && elemset[i].updateDOM();
1150+
if (inViewport(elemset[i].$, verge)) {
1151+
elemset[i].updateDOM();
1152+
}
11371153
});
11381154
}
11391155

0 commit comments

Comments
 (0)
Please sign in to comment.