Optimize predict() from O(n²) to O(n) using pandas groupby#94
Open
BHUVANA-SANKU24 wants to merge 3 commits intoruxailab:mainfrom
Open
Optimize predict() from O(n²) to O(n) using pandas groupby#94BHUVANA-SANKU24 wants to merge 3 commits intoruxailab:mainfrom
BHUVANA-SANKU24 wants to merge 3 commits intoruxailab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Optimization: Reduce predict() complexity from O(n²) to O(n)
Fixes #74
Problem
The existing implementation iterates over each row and repeatedly filters the dataframe, resulting in O(n²) time complexity and poor scalability.
Solution
Replaced the nested iteration with pandas
groupby(["True X", "True Y"]), ensuring each group is processed exactly once.Improvements
Additional Fix
Testing
/api/session/batch_predictendpoint using Postman