Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signals] Options/Params to disable signal handling #199

Open
cocoon opened this issue Feb 17, 2023 · 1 comment
Open

[Signals] Options/Params to disable signal handling #199

cocoon opened this issue Feb 17, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cocoon
Copy link

cocoon commented Feb 17, 2023

Is your feature request related to a problem? Please describe.
The problem is, that when running the server processes manually even with & or nohup the processes end when ssh session is closed.
(no docker available on embedded / router).

I expect this is the source:
https://github.com/rustdesk/rustdesk-server/blob/master/src/common.rs#L154

Describe the solution you'd like
Would be good to have the option to disable specific signal handlers or all, by env vars or commandline arguments.

Describe alternatives you've considered
I tried nohup without luck and the only alternative might be to have a wrapper that blocks these signals for child processes.

https://stackoverflow.com/questions/4515274/externally-disabling-signals-for-a-linux-program
rust-lang/rust#100737

Might be possible with pthread_sigmask somehow.

Currently I use a workaround using the crontab that works but is not ideal.

Additional context
Add any other context about the feature request here.

@cocoon cocoon added the enhancement New feature or request label Feb 17, 2023
@rustdesk
Copy link
Owner

Agree, but PR is welcome.

@rustdesk rustdesk added the help wanted Extra attention is needed label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants