Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for edition 2024 #1584

Open
4 tasks
nicholasbishop opened this issue Mar 22, 2025 · 1 comment · May be fixed by #1586
Open
4 tasks

Plan for edition 2024 #1584

nicholasbishop opened this issue Mar 22, 2025 · 1 comment · May be fixed by #1586

Comments

@nicholasbishop
Copy link
Member

Edition 2024 was stabilized in 1.85. There's no rush to switch to it, but we'll probably want to at some point (once 1.85 is old enough, per our MSRV policy).

Some of the necessary changes can be made prior to actually switching the edition:

  • Switch rustfmt to the 2024 edition. This can be done separately from the edition in Cargo.toml by putting style_edition = "2024" in .rustfmt.toml. See also the style migration guide.
    • Since this will probably affect many lines of code, we might want to add this commit to .git-blame-ignore-revs.
  • Enable the unsafe_op_in_unsafe_fn lint. This lint is enabled by default in 2024, and will affect many of our unsafe functions.
  • Fix some "temporary value dropped while borrowed" errors. There are some changes to temporary lifetimes that affect code in device_path_gen.rs.
@phip1611
Copy link
Member

The diff caused by the new rustfmt edition doesn't look too bad, IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants