Skip to content

Commit fcbdda9

Browse files
test-runner: fix an uninitialized-memory error
Clippy is failing with this error `memory_map`: error: calling `set_len()` immediately after reserving a buffer creates uninitialized values Since the code here is just test code where performance isn't a concern, fully initialize the vec with zeros and drop the unsafe code.
1 parent 55de130 commit fcbdda9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

uefi-test-runner/src/boot/memory.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,7 @@ fn memory_map(bt: &BootServices) {
9191
let buf_sz = map_sz + 8 * mem::size_of::<MemoryDescriptor>();
9292

9393
// We will use vectors for convencience.
94-
let mut buffer = Vec::with_capacity(buf_sz);
95-
96-
unsafe {
97-
buffer.set_len(buf_sz);
98-
}
94+
let mut buffer = vec![0_u8; buf_sz];
9995

10096
let (_key, desc_iter) = bt
10197
.memory_map(&mut buffer)

0 commit comments

Comments
 (0)