Merge pull request #1134 from nicholasbishop/bishop-warnings-fixins-2

Fix some warnings, and ensure CI catches them in the future

Author: phip1611

.github/workflows/rust.yml

@@ -11,6 +11,8 @@ on:
       - version-*
   schedule:
     - cron: '0 0 * * 0-6'
+env:
+  RUSTFLAGS: -D warnings
 jobs:
   test_aarch64:
     name: Integration Test (AArch64)

uefi/src/helpers/mod.rs

@@ -83,13 +83,15 @@ pub fn init(st: &mut SystemTable<Boot>) -> Result<()> {
     // Setup the system table singleton
     SYSTEM_TABLE.store(st.as_ptr().cast_mut(), Ordering::Release);
 
-    unsafe {
-        // Setup logging and memory allocation
+    // Setup logging and memory allocation
 
-        #[cfg(feature = "logger")]
+    #[cfg(feature = "logger")]
+    unsafe {
         logger::init(st);
+    }
 
-        #[cfg(feature = "global_allocator")]
+    #[cfg(feature = "global_allocator")]
+    unsafe {
         uefi::allocator::init(st);
     }
 

uefi/src/table/boot.rs

@@ -1949,8 +1949,6 @@ mod tests {
     use super::{MemoryDescriptor, MemoryMapIter};
 
     fn buffer_to_map(buffer: &mut [MemoryDescriptor]) -> MemoryMap {
-        let desc_count = buffer.len();
-
         let byte_buffer = {
             unsafe {
                 core::slice::from_raw_parts_mut(buffer.as_mut_ptr() as *mut u8, size_of_val(buffer))