Skip to content

Commit 86b339b

Browse files
committed
integration-test: add comment for test order constraint of SNP
1 parent 542793f commit 86b339b

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

uefi-test-runner/src/proto/network/mod.rs

+10-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,17 @@
33
pub fn test() {
44
info!("Testing Network protocols");
55

6-
pxe::test();
7-
snp::test();
6+
#[cfg(feature = "pxe")]
7+
{
8+
pxe::test();
9+
// Currently, we are in the unfortunate situation that the SNP test
10+
// depends on the PXE test, as it assigns an IPv4 address to the
11+
// interface.
12+
snp::test();
13+
}
814
}
915

16+
#[cfg(feature = "pxe")]
1017
mod pxe;
18+
#[cfg(feature = "pxe")]
1119
mod snp;

uefi-test-runner/src/proto/network/pxe.rs

-5
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ use uefi::proto::network::IpAddress;
55
use uefi::{boot, CStr8};
66

77
pub fn test() {
8-
// Skip the test if the `pxe` feature is not enabled.
9-
if cfg!(not(feature = "pxe")) {
10-
return;
11-
}
12-
138
info!("Testing The PXE base code protocol");
149

1510
let handles = boot::find_handles::<BaseCode>().expect("failed to get PXE base code handles");

0 commit comments

Comments
 (0)