You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
redirecting is broken: When we access to /fooDir on GitHub Pages, it tries to redirect to /fooDir/. However, our custom domain isn't configured on GitHub Pages but cloudfront, it will redirect to rust-lang.github.io/thanks/fooDir/.
style is broken: because we use an absolute path and on GitHub Pages domain it will result in 404.
One easy fix is to manage everything on GitHub Pages, I think.
We need cloudfront (or needed) because we want to set some custom headers in responses (e.g., to prevent script injection); I don't know the extent to which that's still necessary, but it was the original rationale.
In terms of the redirects breaking, that makes sense. I think one possibly easy fix is to tell GitHub pages they're on a custom domain (thanks.internal.rust-lang.org) and then maybe that'll fix things in terms of not being relative? Not sure. Maybe something we could intercept at cloudfront layer too.
https://thanks.rust-lang.org/rust/all-time/ -> works
https://thanks.rust-lang.org/rust/all-time -> redirects to https://rust-lang.github.io/thanks/rust/all-time/ which has broken CSS
https://thanks.rust-lang.org/rust/1.59.0/ -> works
https://thanks.rust-lang.org/rust/1.59.0 -> redirects to https://rust-lang.github.io/thanks/rust/1.59.0/ which has broken CSS
etc.
The text was updated successfully, but these errors were encountered: