refactor(dist/component/package): make DirectoryPackage::install() async
#4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`DirectoryPackage::install()`
djc
reviewed
Nov 11, 2025
| let manifest = utils::read_file("package manifest", &root.join("manifest.in"))?; | ||
| let mut builder = target.add(name, tx); | ||
|
|
||
| let yield_timeout = Duration::from_millis(50); |
Contributor
There was a problem hiding this comment.
This is pretty short -- have you tried with longer intervals, like 250/500/1000ms?
Member
Author
There was a problem hiding this comment.
No significant changes on my side with either of those values: the installation is always ~2x slower than latest.
Contributor
There was a problem hiding this comment.
Wow, that seems very surprising.
Contributor
|
(IMO |
rami3l
changed the title
DirectoryPackage::install() asyncDirectoryPackage::install() async
Member
Author
The intention is that it will never be merged instead of passing through the normal state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my local testing it seems that
DirectoryPackage::install()is not a good candidate for the said optimization in https://rust-lang.zulipchat.com/#narrow/channel/490103-t-rustup/topic/Shipping.20fully.20concurrent.20downloads.20of.20rust.20components/near/554900068. On my machine, this has slowed down the installation of thebetatoolchain withdefaultprofile by ~2x.