Skip to content

Sanity check for proxies created during the installation phase #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rami3l opened this issue May 16, 2025 · 1 comment · Fixed by #4338
Closed

Sanity check for proxies created during the installation phase #4336

rami3l opened this issue May 16, 2025 · 1 comment · Fixed by #4338
Assignees
Milestone

Comments

@rami3l
Copy link
Member

rami3l commented May 16, 2025

As suggested by @ChrisDenton:

Previous issues such as #4291 proved that the symlink approach to proxies on Windows could be problematic from time to time.

Maybe we could add a sanity check right after the installation phase for the proxie(s) with a backing binary, say running cargo --version or rustc --version, and see if the proxy can actually work and produce a reasonable output. If it doesn't, we should prompt the user to file an issue in https://github.com/rust-lang/rustup/issues and exit immediately with an error.

Note

  • It's unfortunately not possible to assume any backing binaries to be available at all times. Not all toolchains have cargo, and rustup-init --default-toolchain=none can even leave you without rustc.
  • For packagers who would like to skip the installation phase entirely, the validation verification of proxies should not be our responsibility.
@rami3l rami3l added this to the 1.28.3 milestone May 16, 2025
@rami3l rami3l assigned rami3l and unassigned rami3l May 16, 2025
@manyinsects
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants