Skip to content

Support HTTP over TLS 1.3 on rustup.rs #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanmai-NL opened this issue Mar 17, 2019 · 8 comments
Closed

Support HTTP over TLS 1.3 on rustup.rs #1717

sanmai-NL opened this issue Mar 17, 2019 · 8 comments

Comments

@sanmai-NL
Copy link

The maximum TLS version supported is currently 1.2. TLS 1.3 delivers security and performance benefits.

In terms of security, the distribution mechanism's security currently depends on TLS. Only with TLS 1.3 and the appropriate certificate practical downgrade attacks can be prevented. https://www.nccgroup.trust/uk/about-us/newsroom-and-events/blogs/2019/february/downgrade-attack-on-tls-1.3-and-vulnerabilities-in-major-tls-libraries/

@kinnison
Copy link
Contributor

The rustup website is managed on EC2 - do you happen to know if TLS1.3 is supported by AWS?

@sanmai-NL
Copy link
Author

sanmai-NL commented Mar 18, 2019

@kinnison: I don't know. I have understood AWS uses the s2n implementation for TLS and the s2n maintainership is actively working on TLS 1.3 support (aws/s2n-tls#388).

@kinnison
Copy link
Contributor

I've re-checked and cloudfront currently still don't support TLS1.3

@BryanQuigley
Copy link

AFAICT TLS1.3 support is working now.

@sanmai-NL
Copy link
Author

Do we enforce TLS 1.3 though?

@kinnison
Copy link
Contributor

Do we enforce TLS 1.3 though?

Right now it would not be appropriate to do so because of corporate proxies etc. We will use 1.3 if it's available by preference. I imagine if a system configured openssl to require 1.3 we'd honour that (I think we read the system openssl.cnf)

@kinnison
Copy link
Contributor

There may be some work to do in rustup-init.sh to look for support in system curl/wget though actually. I'll open an issue for that.

@kinnison
Copy link
Contributor

I've filed #2581 to continue the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants