Skip to content

Test test::verify_check_works failing on windows #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-botz opened this issue May 26, 2018 · 3 comments · Fixed by #2745
Closed

Test test::verify_check_works failing on windows #2738

t-botz opened this issue May 26, 2018 · 3 comments · Fixed by #2745
Labels
bug Panic, non-idempotency, invalid code, etc.

Comments

@t-botz
Copy link
Contributor

t-botz commented May 26, 2018

This windows bug happens no matter the git autocrlf configuration.
Here is the result:

---- test::verify_check_works stdout ----
thread 'test::verify_check_works' panicked at 'Assertion failed for `{XXX}\rustfmt\target\debug\rustfmt --check .\temp_check.rs`
with: Unexpected return status: failure
stdout=``````
stderr=```Unrecognized option: 'check'
```', {XXX}\.cargo\registry\src\github.com-1ecc6299db9ec823\assert_cli-0.6.1\src\assert.rs:441:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Where {XXX} is my home folder.

After a git bisect, the responsible commit is 5d9f5aa

@t-botz
Copy link
Contributor Author

t-botz commented May 26, 2018

My bad! Nothing to do with windows...
It actually fails only if you don't run cargo build first...

Not sure if you are ok with that. If yes then feel free to close this issue.

@topecongiro topecongiro added the bug Panic, non-idempotency, invalid code, etc. label May 27, 2018
@t-botz
Copy link
Contributor Author

t-botz commented May 28, 2018

@nrc TLDR; verify_check_works depends on the output of cargo build, are we ok with that?
@topecongiro Since you have added the bug label, does that mean we should avoid doing that? I can do a PR.

@alexheretic
Copy link
Member

alexheretic commented May 28, 2018

I ran into this too while testing #2745, I added an assert that will fail a cargo clean; cargo test run with the message "no rustfmt bin, try running cargo build before testing".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants