Skip to content

no perf run for rustc PR #91486 #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klensy opened this issue Dec 3, 2021 · 1 comment
Closed

no perf run for rustc PR #91486 #1114

klensy opened this issue Dec 3, 2021 · 1 comment

Comments

@klensy
Copy link
Contributor

klensy commented Dec 3, 2021

There no perf run for PR rust-lang/rust#91486, perhaps because of merged\closed issue (mentioned in pr). Queue is empty, runs for next and previous PR successfully finished.

@Mark-Simulacrum
Copy link
Member

The perf run happened, we just didn't report about it. Fixed with a manual insert into the pull_request_build table, we were missing the row for this PR. I'm not sure how this might've happened, since the logic seems like it should have inserted the commit here -- maybe we need to add more logging on that spot.

Since this is pretty rare, and this particular PR had other glitches, I'm going to close this issue for now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants