bootstrap: Miri now handles jemalloc like everything else#149306
Merged
bors merged 1 commit intorust-lang:mainfrom Nov 27, 2025
Merged
bootstrap: Miri now handles jemalloc like everything else#149306bors merged 1 commit intorust-lang:mainfrom
bors merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
Member
|
Hmm, I think that it would be more reasonable to actually start checking the |
Member
Author
|
Honestly I don't understand what this code does at all... it's not Miri-specific so why is that comment even bringing up Miri? |
Member
Author
|
IOW, what does "checking the jemalloc flag" mean? |
Member
|
I think it's trying to say that setting |
Member
|
Yeah, that's it. These env. vars. configure Jemalloc so that it builds in a way that makes it work on Aarch64 systems that have a different page size than the system where jemalloc was built. |
Member
Author
|
Hm, seems fine to just always set the env var no matter whether it is actually needed or not... but sure I can add such a check. |
RalfJung
force-pushed
the
bootstra-miri-jemalloc
branch
from
3513bf4 to
3a91d34
Compare
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
RalfJung
changed the title
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 26, 2025
…=Kobzol bootstrap: Miri now handles jemalloc like everything else rust-lang#149252 made Miri work like clippy here, so I think this comment can be removed?
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 26, 2025
…=Kobzol bootstrap: Miri now handles jemalloc like everything else rust-lang#149252 made Miri work like clippy here, so I think this comment can be removed?
bors
added a commit
that referenced
this pull request
Nov 26, 2025
Rollup of 19 pull requests Successful merges: - #148048 (Stabilize `maybe_uninit_write_slice`) - #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls) - #148765 (std: split up the `thread` module) - #149074 (Add Command::get_env_clear) - #149097 (num: Implement `uint_gather_scatter_bits` feature for unsigned integers) - #149131 (optimize `slice::Iter::next_chunk`) - #149190 (Forbid `CHECK: br` and `CHECK-NOT: br` in codegen tests (suggest `br {{.*}}` instead)) - #149239 (clarify float min/max behavios for NaNs and signed zeros) - #149243 (Fix typo and clarify bootstrap change tracker entry) - #149270 (implement `Iterator::{exactly_one, collect_array}`) - #149295 (Suggest _bytes versions of endian-converting methods) - #149301 (Motor OS: make decode_error_kind more comprehensive) - #149306 (bootstrap: Miri now handles jemalloc like everything else) - #149325 (rustdoc: add regression test for #140968) - #149332 (fix rustdoc search says “Consider searching for "null" instead.” #149324) - #149349 (Fix typo in comment.) - #149353 (Tidying up UI tests [3/N]) - #149355 (Document that `build.description` affects symbol mangling and crate IDs) - #149360 (Enable CI download for windows-gnullvm) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Nov 27, 2025
Rollup of 12 pull requests Successful merges: - #147115 (More robust stack protector testing) - #148048 (Stabilize `maybe_uninit_write_slice`) - #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls) - #149074 (Add Command::get_env_clear) - #149097 (num: Implement `uint_gather_scatter_bits` feature for unsigned integers) - #149131 (optimize `slice::Iter::next_chunk`) - #149190 (Forbid `CHECK: br` and `CHECK-NOT: br` in codegen tests (suggest `br {{.*}}` instead)) - #149239 (clarify float min/max behavios for NaNs and signed zeros) - #149243 (Fix typo and clarify bootstrap change tracker entry) - #149301 (Motor OS: make decode_error_kind more comprehensive) - #149306 (bootstrap: Miri now handles jemalloc like everything else) - #149325 (rustdoc: add regression test for #140968) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#149252 made Miri work like clippy here, so I think this comment can be removed?