From df033a1e974bddb1c545bda546eb2469e177e3a4 Mon Sep 17 00:00:00 2001
From: George Tokmaji <tokmajigeorge@gmail.com>
Date: Fri, 7 Mar 2025 00:10:49 +0100
Subject: [PATCH] Win: Fix std::fs::rename failing on Windows Server by
 attempting the non-atomic rename first

We previously attempted the atomic rename first, and fell back to trying a non-atomic rename
if it wasn't supported. However, this does not work reliably on Windows Server - NTFS partitions
created in Windows Server 2016 apparently need to be upgraded, and it outright fails with
`ERROR_NOT_SUPPORTED` on ReFS on Windows Server 2022.

This commit switches the two calls so that FileRenameInfo is tried first, and an atomic rename via
FileRenameInfoEx is only attempted if the non-atomic rename fails.
---
 library/std/src/sys/pal/windows/fs.rs | 44 +++++++++++++++++----------
 1 file changed, 28 insertions(+), 16 deletions(-)

diff --git a/library/std/src/sys/pal/windows/fs.rs b/library/std/src/sys/pal/windows/fs.rs
index 623a7d89ba5a0..1e2a321da0254 100644
--- a/library/std/src/sys/pal/windows/fs.rs
+++ b/library/std/src/sys/pal/windows/fs.rs
@@ -1338,9 +1338,8 @@ pub fn rename(old: &Path, new: &Path) -> io::Result<()> {
 
     // SAFETY: We have allocated enough memory for a full FILE_RENAME_INFO struct and a filename.
     unsafe {
-        (&raw mut (*file_rename_info).Anonymous).write(c::FILE_RENAME_INFO_0 {
-            Flags: c::FILE_RENAME_FLAG_REPLACE_IF_EXISTS | c::FILE_RENAME_FLAG_POSIX_SEMANTICS,
-        });
+        (&raw mut (*file_rename_info).Anonymous)
+            .write(c::FILE_RENAME_INFO_0 { ReplaceIfExists: true });
 
         (&raw mut (*file_rename_info).RootDirectory).write(ptr::null_mut());
         (&raw mut (*file_rename_info).FileNameLength).write(new_len_without_nul_in_bytes);
@@ -1353,31 +1352,44 @@ pub fn rename(old: &Path, new: &Path) -> io::Result<()> {
     let result = unsafe {
         cvt(c::SetFileInformationByHandle(
             handle.as_raw_handle(),
-            c::FileRenameInfoEx,
+            c::FileRenameInfo,
             (&raw const *file_rename_info).cast::<c_void>(),
             struct_size,
         ))
     };
 
-    if let Err(err) = result {
-        if err.raw_os_error() == Some(c::ERROR_INVALID_PARAMETER as _) {
-            // FileRenameInfoEx and FILE_RENAME_FLAG_POSIX_SEMANTICS were added in Windows 10 1607; retry with FileRenameInfo.
-            file_rename_info.Anonymous.ReplaceIfExists = true;
-
-            cvt(unsafe {
+    match result {
+        Ok(_) => Ok(()),
+        Err(err) if err.raw_os_error() == Some(c::ERROR_ACCESS_DENIED as _) => {
+            // If a process already has an open file handle to the target file, we need POSIX rename semantics to succeed
+            // (open file handles still refer to the old file, but the path will refer to the new file).
+            // As this is only supported starting with Windows 10 1607 and does not work out of the box on some versions
+            // of Windows Server, we only try this if the initial rename failed.
+            file_rename_info.Anonymous.Flags =
+                c::FILE_RENAME_FLAG_REPLACE_IF_EXISTS | c::FILE_RENAME_FLAG_POSIX_SEMANTICS;
+
+            let result = cvt(unsafe {
                 c::SetFileInformationByHandle(
                     handle.as_raw_handle(),
-                    c::FileRenameInfo,
+                    c::FileRenameInfoEx,
                     (&raw const *file_rename_info).cast::<c_void>(),
                     struct_size,
                 )
-            })?;
-        } else {
-            return Err(err);
+            });
+
+            match result {
+                Ok(_) => Ok(()),
+                Err(err) if err.raw_os_error() == Some(c::ERROR_INVALID_PARAMETER as _) => {
+                    // FileRenameInfoEx was only tried because the initial rename failed with ERROR_ACCESS_DENIED.
+                    // If FileRenameInfoEx isn't supported, return the original error as ERROR_INVALID_PARAMETER
+                    // doesn't convey useful error information.
+                    Err(io::Error::from_raw_os_error(c::ERROR_ACCESS_DENIED as _))
+                }
+                Err(err) => Err(err),
+            }
         }
+        Err(err) => Err(err),
     }
-
-    Ok(())
 }
 
 pub fn rmdir(p: &Path) -> io::Result<()> {