Skip to content

Nonlinearity in check_mod_privacy pass for a large number of impls #81263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
weiznich opened this issue Jan 22, 2021 · 0 comments
Open

Nonlinearity in check_mod_privacy pass for a large number of impls #81263

weiznich opened this issue Jan 22, 2021 · 0 comments
Labels
A-visibility Area: Visibility / privacy C-bug Category: This is a bug. I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@weiznich
Copy link
Contributor

weiznich commented Jan 22, 2021 •
edited
Loading

This is a followup issue to rust-lang/rustc-perf#807, where I've suggested to add diesel with the 128-column-tables enabled to the rustc-perf test-suite as this is taking quite a lot of time to compile. As part of that request we discovered that the check_mod_privacy pass scales non-linear with the number of code lines. See the linked PR for the exact numbers. I suspect that this is somehow related to a large number of trait impls for tuples of various sizes.

@rustbot modify labels: +I-slow
@weiznich weiznich added the C-bug Category: This is a bug. label Jan 22, 2021
@rustbot rustbot added the I-slow Issue: Problems and improvements with respect to performance of generated code. label Jan 22, 2021
@estebank estebank added A-visibility Area: Visibility / privacy T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-visibility Area: Visibility / privacy C-bug Category: This is a bug. I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estebank @weiznich @rustbot