Skip to content

clippy-driver no longer builds after rust-lang/rust#64209 #64215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rust-highfive opened this issue Sep 6, 2019 · 2 comments · Fixed by #64307
Closed

clippy-driver no longer builds after rust-lang/rust#64209 #64215

rust-highfive opened this issue Sep 6, 2019 · 2 comments · Fixed by #64307
Assignees
@oli-obk @Manishearth @phansch @mcarton @llogiq @flip1995
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #64209, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2019
@Centril
Copy link
Contributor

Centril commented Sep 6, 2019

I suspect the or-pattern PR, #64111, is to blame.

@mati865
Copy link
Contributor

mati865 commented Sep 6, 2019

Fix for Clippy repo: rust-lang/rust-clippy#4512

@mati865 mati865 mentioned this issue Sep 6, 2019
Closed
@tesuji tesuji mentioned this issue Sep 9, 2019
Merged
@bors bors closed this as completed in 55f067b Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update clippy tesuji/rustc
Update Clippy mati865/rust
9 participants
@oli-obk @Centril @mati865 @Manishearth @phansch @mcarton @llogiq @rust-highfive @flip1995