Skip to content

Commit d814af9

Browse files
authored
Rollup merge of #90100 - Mark-Simulacrum:speed-macos-ci, r=pietroalbini
Skip documentation for tier 2 targets on dist-x86_64-apple-darwin I don't have an easy way to test this locally, but I believe it should work. Based on one log result should shave ~14 minutes off the dist-x86_64-apple builder (doesn't help with aarch64 dist or x86_64 test builder, so not actually decreasing total CI time most likely). r? ```@pietroalbini```
2 parents 87822b2 + 9296efe commit d814af9

File tree

3 files changed

+26
-7
lines changed

3 files changed

+26
-7
lines changed

.github/workflows/ci.yml

+11-4
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ jobs:
287287
os: ubuntu-latest-xl
288288
- name: dist-x86_64-apple
289289
env:
290-
SCRIPT: "./x.py dist"
290+
SCRIPT: "./x.py dist --exclude src/doc --exclude extended && ./x.py dist --target=x86_64-apple-darwin src/doc && ./x.py dist extended"
291291
RUST_CONFIGURE_ARGS: "--host=x86_64-apple-darwin --target=x86_64-apple-darwin,aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim --enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false"
292292
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
293293
MACOSX_DEPLOYMENT_TARGET: 10.7
@@ -532,9 +532,16 @@ jobs:
532532
strategy:
533533
matrix:
534534
include:
535-
- name: dist-x86_64-linux
536-
os: ubuntu-latest-xl
537-
env: {}
535+
- name: dist-x86_64-apple
536+
env:
537+
SCRIPT: "./x.py dist --exclude src/doc --exclude extended && ./x.py dist --target=x86_64-apple-darwin src/doc && ./x.py dist extended"
538+
RUST_CONFIGURE_ARGS: "--host=x86_64-apple-darwin --target=x86_64-apple-darwin,aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim --enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false"
539+
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
540+
MACOSX_DEPLOYMENT_TARGET: 10.7
541+
NO_LLVM_ASSERTIONS: 1
542+
NO_DEBUG_ASSERTIONS: 1
543+
DIST_REQUIRE_ALL_TOOLS: 1
544+
os: macos-latest
538545
timeout-minutes: 600
539546
runs-on: "${{ matrix.os }}"
540547
steps:

src/ci/github-actions/ci.yml

+14-2
Original file line numberDiff line numberDiff line change
@@ -448,9 +448,11 @@ jobs:
448448
# macOS Builders #
449449
####################
450450

451+
# Only generate documentation for x86_64-apple-darwin, not other
452+
# tier 2 targets produced by this builder.
451453
- name: dist-x86_64-apple
452454
env:
453-
SCRIPT: ./x.py dist
455+
SCRIPT: ./x.py dist --exclude src/doc --exclude extended && ./x.py dist --target=x86_64-apple-darwin src/doc && ./x.py dist extended
454456
RUST_CONFIGURE_ARGS: --host=x86_64-apple-darwin --target=x86_64-apple-darwin,aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim --enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false
455457
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
456458
MACOSX_DEPLOYMENT_TARGET: 10.7
@@ -670,7 +672,17 @@ jobs:
670672
strategy:
671673
matrix:
672674
include:
673-
- *dist-x86_64-linux
675+
- name: dist-x86_64-apple
676+
env:
677+
SCRIPT: ./x.py dist --exclude src/doc --exclude extended && ./x.py dist --target=x86_64-apple-darwin src/doc && ./x.py dist extended
678+
RUST_CONFIGURE_ARGS: --host=x86_64-apple-darwin --target=x86_64-apple-darwin,aarch64-apple-ios,x86_64-apple-ios,aarch64-apple-ios-sim --enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false
679+
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
680+
MACOSX_DEPLOYMENT_TARGET: 10.7
681+
NO_LLVM_ASSERTIONS: 1
682+
NO_DEBUG_ASSERTIONS: 1
683+
DIST_REQUIRE_ALL_TOOLS: 1
684+
<<: *job-macos-xl
685+
674686

675687
master:
676688
name: master

src/ci/run.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ else
4343
PYTHON="python2"
4444
fi
4545

46-
if ! isCI || isCiBranch auto || isCiBranch beta; then
46+
if ! isCI || isCiBranch auto || isCiBranch beta || isCiBranch try; then
4747
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set build.print-step-timings --enable-verbose-tests"
4848
fi
4949

0 commit comments

Comments
 (0)