Skip to content

Commit ca0b89a

Browse files
committed
rustc_span: note the perf loss seen from IndexSet in symbol::Interner
1 parent 1d03ffe commit ca0b89a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/librustc_span/symbol.rs

+4
Original file line numberDiff line numberDiff line change
@@ -1481,6 +1481,10 @@ impl<CTX> ToStableHashKey<CTX> for Symbol {
14811481
}
14821482

14831483
// The `&'static str`s in this type actually point into the arena.
1484+
//
1485+
// The `FxHashMap`+`Vec` pair could be replaced by `FxIndexSet`, but #75278
1486+
// found that to regress performance up to 2% in some cases. This might be
1487+
// revisited after further improvements to `indexmap`.
14841488
#[derive(Default)]
14851489
pub struct Interner {
14861490
arena: DroplessArena,

0 commit comments

Comments
 (0)