Skip to content

Commit c4f7176

Browse files
committed
Auto merge of #130959 - tgross35:f16-f128-only-disable-win-gnu, r=joboet
Enable `f16` tests on non-GNU Windows There is a MinGW ABI bug that prevents `f16` and `f128` from being usable on `windows-gnu` targets. This does not affect MSVC; however, we have `f16` and `f128` tests disabled on all Windows targets. Update the gating to only affect `windows-gnu`, which means `f16` tests will be enabled. There is no effect for `f128` since the default fallback is `false`. try-job: x86_64-msvc try-job: i686-msvc
2 parents 21aa500 + 6b09a93 commit c4f7176

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

library/std/build.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ fn main() {
101101
// Unsupported <https://github.com/llvm/llvm-project/issues/94434>
102102
("arm64ec", _) => false,
103103
// MinGW ABI bugs <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054>
104-
("x86_64", "windows") => false,
104+
("x86_64", "windows") if target_env == "gnu" => false,
105105
// Infinite recursion <https://github.com/llvm/llvm-project/issues/97981>
106106
("csky", _) => false,
107107
("hexagon", _) => false,
@@ -129,10 +129,10 @@ fn main() {
129129
// ABI unsupported <https://github.com/llvm/llvm-project/issues/41838>
130130
("sparc", _) => false,
131131
// MinGW ABI bugs <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054>
132-
("x86_64", "windows") => false,
132+
("x86_64", "windows") if target_env == "gnu" => false,
133133
// 64-bit Linux is about the only platform to have f128 symbols by default
134134
(_, "linux") if target_pointer_width == 64 => true,
135-
// Same as for f16, except MacOS is also missing f128 symbols.
135+
// Almost all OSs are missing symbol. compiler-builtins will have to add them.
136136
_ => false,
137137
};
138138

0 commit comments

Comments
 (0)