Skip to content

Commit bf2e892

Browse files
committed
coverage: Use variable name this in CoverageGraph::from_mir
This makes it easier to see that we're manipulating the instance that is being constructed, and is a lot less verbose than `basic_coverage_blocks`.
1 parent 6351247 commit bf2e892

File tree

1 file changed

+6
-7
lines changed
  • compiler/rustc_mir_transform/src/coverage

1 file changed

+6
-7
lines changed

compiler/rustc_mir_transform/src/coverage/graph.rs

+6-7
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,18 @@ impl CoverageGraph {
5252
}
5353
}
5454

55-
let mut basic_coverage_blocks =
56-
Self { bcbs, bb_to_bcb, successors, predecessors, dominators: None };
57-
let dominators = dominators::dominators(&basic_coverage_blocks);
58-
basic_coverage_blocks.dominators = Some(dominators);
55+
let mut this = Self { bcbs, bb_to_bcb, successors, predecessors, dominators: None };
56+
57+
this.dominators = Some(dominators::dominators(&this));
5958

6059
// The coverage graph's entry-point node (bcb0) always starts with bb0,
6160
// which never has predecessors. Any other blocks merged into bcb0 can't
6261
// have multiple (coverage-relevant) predecessors, so bcb0 always has
6362
// zero in-edges.
64-
assert!(basic_coverage_blocks[START_BCB].leader_bb() == mir::START_BLOCK);
65-
assert!(basic_coverage_blocks.predecessors[START_BCB].is_empty());
63+
assert!(this[START_BCB].leader_bb() == mir::START_BLOCK);
64+
assert!(this.predecessors[START_BCB].is_empty());
6665

67-
basic_coverage_blocks
66+
this
6867
}
6968

7069
fn compute_basic_coverage_blocks(

0 commit comments

Comments
 (0)