Update test

Author: obeis

compiler/rustc_driver_impl/src/signal_handler.rs

@@ -34,6 +34,8 @@ macro raw_errln($tokens:tt) {
 }
 
 /// Signal handler installed for SIGSEGV
+// FIXME(obeis): Use `SyncUnsafeCell` instead of allowing `static_mut_refs` lint
+#[allow(static_mut_refs)]
 extern "C" fn print_stack_trace(_: libc::c_int) {
     const MAX_FRAMES: usize = 256;
     // Reserve data segment so we don't have to malloc in a signal handler, which might fail

library/alloc/tests/vec.rs

@@ -1285,6 +1285,8 @@ fn test_from_iter_specialization_panic_during_iteration_drops() {
 
 #[test]
 #[cfg_attr(not(panic = "unwind"), ignore = "test requires unwinding support")]
+// FIXME(obeis): Use `SyncUnsafeCell` instead of allowing `static_mut_ref` lint
+#[cfg_attr(not(bootstrap), allow(static_mut_refs))]
 fn test_from_iter_specialization_panic_during_drop_doesnt_leak() {
     static mut DROP_COUNTER_OLD: [usize; 5] = [0; 5];
     static mut DROP_COUNTER_NEW: [usize; 2] = [0; 2];

library/core/tests/atomic.rs

@@ -228,6 +228,8 @@ fn static_init() {
 }
 
 #[test]
+// FIXME(obeis): Use `SyncUnsafeCell` instead of allowing `static_mut_ref` lint
+#[cfg_attr(not(bootstrap), allow(static_mut_refs))]
 fn atomic_access_bool() {
     static mut ATOMIC: AtomicBool = AtomicBool::new(false);
 

src/tools/clippy/tests/ui/checked_unwrap/simple_conditionals.rs

@@ -173,8 +173,10 @@ fn issue11371() {
     static mut X: Option<i32> = Some(123);
     unsafe {
         if X.is_some() {
+            //~^ ERROR: creating a shared reference to mutable static is discouraged
             X = None;
             X.unwrap();
+            //~^ ERROR: creating a shared reference to mutable static is discouraged
         }
     }
 }

src/tools/clippy/tests/ui/checked_unwrap/simple_conditionals.stderr

@@ -1,3 +1,25 @@
+error: creating a shared reference to mutable static is discouraged
+  --> tests/ui/checked_unwrap/simple_conditionals.rs:175:12
+   |
+LL |         if X.is_some() {
+   |            ^^^^^^^^^^^ shared reference to mutable static
+   |
+   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
+   = note: this will be a hard error in the 2024 edition
+   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
+   = note: `-D static-mut-refs` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(static_mut_refs)]`
+
+error: creating a shared reference to mutable static is discouraged
+  --> tests/ui/checked_unwrap/simple_conditionals.rs:178:13
+   |
+LL |             X.unwrap();
+   |             ^^^^^^^^^^ shared reference to mutable static
+   |
+   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
+   = note: this will be a hard error in the 2024 edition
+   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
+
 error: called `unwrap` on `x` after checking its variant with `is_some`
   --> tests/ui/checked_unwrap/simple_conditionals.rs:47:9
    |
@@ -236,5 +258,5 @@ LL |     if result.is_ok() {
 LL |         result.as_mut().unwrap();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 25 previous errors
+error: aborting due to 27 previous errors
 

src/tools/clippy/tests/ui/redundant_static_lifetimes.fixed

@@ -44,6 +44,7 @@ fn main() {
 
     unsafe {
         STATIC_MUT_SLICE[0] = 0;
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
     }
 }
 

src/tools/clippy/tests/ui/redundant_static_lifetimes.rs

@@ -44,6 +44,7 @@ fn main() {
 
     unsafe {
         STATIC_MUT_SLICE[0] = 0;
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
     }
 }
 

src/tools/clippy/tests/ui/redundant_static_lifetimes.stderr

@@ -104,10 +104,22 @@ LL | static mut STATIC_MUT_SLICE: &'static mut [u32] = &mut [0];
    |                              -^^^^^^^---------- help: consider removing `'static`: `&mut [u32]`
 
 error: statics have by default a `'static` lifetime
-  --> tests/ui/redundant_static_lifetimes.rs:69:16
+  --> tests/ui/redundant_static_lifetimes.rs:70:16
    |
 LL |     static V: &'static u8 = &17;
    |               -^^^^^^^--- help: consider removing `'static`: `&u8`
 
-error: aborting due to 18 previous errors
+error: creating a shared reference to mutable static is discouraged
+  --> tests/ui/redundant_static_lifetimes.rs:46:9
+   |
+LL |         STATIC_MUT_SLICE[0] = 0;
+   |         ^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
+   |
+   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
+   = note: this will be a hard error in the 2024 edition
+   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
+   = note: `-D static-mut-refs` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(static_mut_refs)]`
+
+error: aborting due to 19 previous errors
 

src/tools/clippy/tests/ui/useless_conversion.fixed

@@ -97,9 +97,13 @@ fn dont_lint_into_iter_on_static_copy_iter() {
     static mut C: CopiableCounter = CopiableCounter { counter: 0 };
     unsafe {
         assert_eq!(C.into_iter().next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.into_iter().next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.next(), Some(2));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
     }
 }
 

src/tools/clippy/tests/ui/useless_conversion.rs

@@ -97,9 +97,13 @@ fn dont_lint_into_iter_on_static_copy_iter() {
     static mut C: CopiableCounter = CopiableCounter { counter: 0 };
     unsafe {
         assert_eq!(C.into_iter().next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.into_iter().next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.next(), Some(1));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
         assert_eq!(C.next(), Some(2));
+        //~^ ERROR: creating a shared reference to mutable static is discouraged
     }
 }