Skip to content

Commit 2b49944

Browse files
committed
Auto merge of #49527 - petrhosek:fast-submodules, r=alexcrichton
Handle fast-submodules option correctly This option was introduced in 72cb109, but it uses two different spellings (`fast-submodule` in `bootstrap.py` vs `fast-submodules` in `config.toml.example`) and isn't handled by Rust bootstrap which means that any attempt to set this flag fails.
2 parents 517f240 + a24811e commit 2b49944

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/bootstrap/bootstrap.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ def update_submodules(self):
647647
if (not os.path.exists(os.path.join(self.rust_root, ".git"))) or \
648648
self.get_toml('submodules') == "false":
649649
return
650-
slow_submodules = self.get_toml('fast-submodule') == "false"
650+
slow_submodules = self.get_toml('fast-submodules') == "false"
651651
start_time = time()
652652
if slow_submodules:
653653
print('Unconditionally updating all submodules')

src/bootstrap/config.rs

+4
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ pub struct Config {
4545
pub ninja: bool,
4646
pub verbose: usize,
4747
pub submodules: bool,
48+
pub fast_submodules: bool,
4849
pub compiler_docs: bool,
4950
pub docs: bool,
5051
pub locked_deps: bool,
@@ -191,6 +192,7 @@ struct Build {
191192
compiler_docs: Option<bool>,
192193
docs: Option<bool>,
193194
submodules: Option<bool>,
195+
fast_submodules: Option<bool>,
194196
gdb: Option<String>,
195197
locked_deps: Option<bool>,
196198
vendor: Option<bool>,
@@ -328,6 +330,7 @@ impl Config {
328330
config.rust_optimize = true;
329331
config.rust_optimize_tests = true;
330332
config.submodules = true;
333+
config.fast_submodules = true;
331334
config.docs = true;
332335
config.rust_rpath = true;
333336
config.channel = "dev".to_string();
@@ -404,6 +407,7 @@ impl Config {
404407
set(&mut config.compiler_docs, build.compiler_docs);
405408
set(&mut config.docs, build.docs);
406409
set(&mut config.submodules, build.submodules);
410+
set(&mut config.fast_submodules, build.fast_submodules);
407411
set(&mut config.locked_deps, build.locked_deps);
408412
set(&mut config.vendor, build.vendor);
409413
set(&mut config.full_bootstrap, build.full_bootstrap);

0 commit comments

Comments
 (0)