Skip to content

change versioning scheme of clippy_lints #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oli-obk opened this issue May 15, 2018 · 0 comments
Open

change versioning scheme of clippy_lints #2761

oli-obk opened this issue May 15, 2018 · 0 comments
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 15, 2018

As mentioned in rust-lang/rust#50767, updating the clippy submodule in the rustc repo can break rls and thus break nightlies.

Yesssss!, we can now ensure that all nightlies have a working clippy if we want to

No we are of course not doing this :P

Anyway. My suggestion is to change the versioning scheme of the clippy_lints crate. Instead of syncing with the clippy crate, we start producing 0.x.y versions, where x is updated when we change the API of clippy_lints (so when rustc forces us to change the API) and y is updated whenever we do a rustup.

This means there'll be a lot fewer version bumps to the clippy crate, as the clippy_lints crate in the background would automatically update via patch versions.

Is this suggestion abusing semver? Other ideas?

@oli-obk oli-obk added the S-needs-discussion Status: Needs further discussion before merging or work can be started label May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Development

No branches or pull requests

1 participant