Add lint to suggest into()

Author: rudyardrichter

CHANGELOG.md

@@ -654,6 +654,7 @@ All notable changes to this project will be documented in this file.
 [`explicit_iter_loop`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#explicit_iter_loop
 [`explicit_write`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#explicit_write
 [`extend_from_slice`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#extend_from_slice
+[`extra_unused_lifetimes`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
 [`fallible_impl_from`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#fallible_impl_from
 [`filter_map`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#filter_map
 [`filter_next`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#filter_next
@@ -835,9 +836,9 @@ All notable changes to this project will be documented in this file.
 [`unused_collect`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unused_collect
 [`unused_io_amount`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unused_io_amount
 [`unused_label`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unused_label
-[`unused_lifetimes`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unused_lifetimes
 [`use_debug`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#use_debug
 [`use_self`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#use_self
+[`use_shared_from_slice`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#use_shared_from_slice
 [`used_underscore_binding`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#used_underscore_binding
 [`useless_asref`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#useless_asref
 [`useless_attribute`]: https://rust-lang-nursery.github.io/rust-clippy/master/index.html#useless_attribute

README.md

@@ -7,7 +7,7 @@
 
 A collection of lints to catch common mistakes and improve your [Rust](https://github.com/rust-lang/rust) code.
 
-[There are 259 lints included in this crate!](https://rust-lang-nursery.github.io/rust-clippy/master/index.html)
+[There are 260 lints included in this crate!](https://rust-lang-nursery.github.io/rust-clippy/master/index.html)
 
 We have a bunch of lint categories to allow you to choose how much clippy is supposed to ~~annoy~~ help you:
 

clippy_lints/src/lib.rs

@@ -201,6 +201,7 @@ pub mod unsafe_removed_from_name;
 pub mod unused_io_amount;
 pub mod unused_label;
 pub mod use_self;
+pub mod use_shared_from_slice;
 pub mod vec;
 pub mod write;
 pub mod zero_div_zero;
@@ -542,8 +543,8 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         len_zero::LEN_WITHOUT_IS_EMPTY,
         len_zero::LEN_ZERO,
         let_if_seq::USELESS_LET_IF_SEQ,
-        lifetimes::NEEDLESS_LIFETIMES,
         lifetimes::EXTRA_UNUSED_LIFETIMES,
+        lifetimes::NEEDLESS_LIFETIMES,
         literal_representation::INCONSISTENT_DIGIT_GROUPING,
         literal_representation::LARGE_DIGIT_GROUPS,
         literal_representation::UNREADABLE_LITERAL,
@@ -785,8 +786,8 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         identity_conversion::IDENTITY_CONVERSION,
         identity_op::IDENTITY_OP,
         int_plus_one::INT_PLUS_ONE,
-        lifetimes::NEEDLESS_LIFETIMES,
         lifetimes::EXTRA_UNUSED_LIFETIMES,
+        lifetimes::NEEDLESS_LIFETIMES,
         loops::EXPLICIT_COUNTER_LOOP,
         loops::MUT_RANGE_BOUND,
         loops::WHILE_LET_LOOP,
@@ -910,6 +911,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         mutex_atomic::MUTEX_INTEGER,
         needless_borrow::NEEDLESS_BORROW,
         ranges::RANGE_PLUS_ONE,
+        use_shared_from_slice::USE_SHARED_FROM_SLICE,
     ]);
 }
 

clippy_lints/src/use_shared_from_slice.rs

@@ -0,0 +1,69 @@
+use rustc::hir::Expr;
+use rustc::lint::{LateContext, LateLintPass, LintArray, LintContext, LintPass};
+use rustc::ty;
+use utils::{match_type, span_lint_and_sugg, walk_ptrs_ty};
+use utils::paths;
+
+/// **What it does:**
+/// Checks for usage of `Rc<String>` or `Rc<Vec<T>>`.
+///
+/// **Why is this bad?**
+/// Using a `Rc<str>` or `Rc<[T]>` is more efficient and easy to construct with
+/// `into()`.
+///
+/// **Known problems:**
+/// None.
+///
+/// **Example:**
+///
+/// ```rust
+/// use std::rc::Rc;
+///
+/// // Bad
+/// let bad_ref: Rc<Vec<usize>> = Rc::new(vec!(1, 2, 3));
+///
+/// // Good
+/// let good_ref: Rc<[usize]> = Rc::new(vec!(1, 2, 3).into());
+/// ```
+declare_clippy_lint! {
+    pub USE_SHARED_FROM_SLICE,
+    nursery,
+    "use `into()` to construct `Rc` from slice"
+}
+
+#[derive(Copy, Clone, Debug)]
+pub struct Pass;
+
+impl LintPass for Pass {
+    fn get_lints(&self) -> LintArray {
+        lint_array!(USE_SHARED_FROM_SLICE)
+    }
+}
+
+impl <'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
+    fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
+        let expr_ty = walk_ptrs_ty(cx.tables.expr_ty(expr));
+
+        // Check for expressions with the type `Rc<Vec<T>>`.
+        if_chain! {
+            if let ty::TyAdt(_, subst) = expr_ty.sty;
+            if match_type(cx, expr_ty, &paths::RC);
+            if match_type(cx, subst.type_at(1), &paths::VEC);
+            then {
+                span_lint_and_sugg(
+                    cx,
+                    USE_SHARED_FROM_SLICE,
+                    expr.span,
+                    "constructing reference-counted type from vec",
+                    "consider using `into()`",
+                    format!("TODO"),
+                );
+            }
+        }
+
+        // TODO
+        // Check for expressions with the type `Rc<String>`.
+        // Check for expressions with the type `Arc<String>`.
+        // Check for expressions with the type `Arc<Vec<T>>`.
+    }
+}

tests/ui/use_shared_from_slice.rs

@@ -0,0 +1,7 @@
+use std::rc::Rc;
+
+fn main() {
+    let bad_ref: Rc<Vec<usize>> = Rc::new(vec!(1, 2, 3));
+
+    let good_ref: Rc<[usize]> = Rc::new(vec!(1, 2, 3).into());
+}