Fix clippy warnings.

Author: reitermarkus

bindgen/ir/context.rs

@@ -26,7 +26,6 @@ use crate::codegen::utils::{fnsig_argument_type, fnsig_return_ty_internal};
 use crate::codegen::CodegenError;
 use crate::BindgenOptions;
 use crate::{Entry, HashMap, HashSet};
-use clang_sys;
 use proc_macro2::{Ident, Span, TokenStream};
 use quote::ToTokens;
 use std::borrow::Cow;
@@ -1479,22 +1478,26 @@ If you encounter an error missing from this list, please file an issue or a PR!"
         self.root_module
     }
 
-    /// Resolve a type with the given id.
+    /// Resolve a type with the given ID.
     ///
     /// Panics if there is no item for the given `TypeId` or if the resolved
     /// item is not a `Type`.
     pub(crate) fn resolve_type(&self, type_id: TypeId) -> &Type {
         self.resolve_item(type_id).kind().expect_type()
     }
 
-    /// Resolve a function with the given id.
+    /// Resolve a function with the given ID.
     ///
     /// Panics if there is no item for the given `FunctionId` or if the resolved
     /// item is not a `Function`.
     pub(crate) fn resolve_func(&self, func_id: FunctionId) -> &Function {
         self.resolve_item(func_id).kind().expect_function()
     }
 
+    /// Resolve a function signature with the given ID.
+    ///
+    /// Panics if there is no type for the given `TypeId` or if the resolved
+    /// `Type` is not a function.
     pub(crate) fn resolve_sig(&self, sig_id: TypeId) -> &FunctionSig {
         let signature = self.resolve_type(sig_id).canonical_type(self);
         match *signature.kind() {
@@ -1504,9 +1507,9 @@ If you encounter an error missing from this list, please file an issue or a PR!"
     }
 
     /// Resolve the given `ItemId` as a type, or `None` if there is no item with
-    /// the given id.
+    /// the given ID.
     ///
-    /// Panics if the id resolves to an item that is not a type.
+    /// Panics if the ID resolves to an item that is not a type.
     pub(crate) fn safe_resolve_type(&self, type_id: TypeId) -> Option<&Type> {
         self.resolve_item_fallible(type_id)
             .map(|t| t.kind().expect_type())
@@ -1523,7 +1526,7 @@ If you encounter an error missing from this list, please file an issue or a PR!"
 
     /// Resolve the given `ItemId` into an `Item`.
     ///
-    /// Panics if the given id does not resolve to any item.
+    /// Panics if the given ID does not resolve to any item.
     pub(crate) fn resolve_item<Id: Into<ItemId>>(&self, item_id: Id) -> &Item {
         let item_id = item_id.into();
         match self.resolve_item_fallible(item_id) {
@@ -2009,32 +2012,39 @@ If you encounter an error missing from this list, please file an issue or a PR!"
         type_id
     }
 
+    /// Add a function signature in order to look it up when generating macros.
     pub(crate) fn add_function(&mut self, name: &str, sig: Function) {
         self.functions.insert(name.to_owned(), sig);
     }
 
+    /// Get a function signature by its name.
     pub(crate) fn function(&self, name: &str) -> Option<&Function> {
         self.functions.get(name)
     }
 
+    /// Add a function-like macro.
     pub(crate) fn add_fn_macro(&mut self, fn_macro: cmacro::FnMacro) {
         self.function_macros
             .insert(fn_macro.name.to_owned(), fn_macro);
     }
 
+    /// Get a function-like macro by its name.
     pub(crate) fn fn_macro(&self, name: &str) -> Option<&cmacro::FnMacro> {
         self.function_macros.get(name)
     }
 
+    /// Add a variable-like macro.
     pub(crate) fn add_var_macro(&mut self, var_macro: cmacro::VarMacro) {
         self.variable_macros
             .insert(var_macro.name.to_owned(), var_macro);
     }
 
+    /// Get a variable-like macro by its name.
     pub(crate) fn var_macro(&self, name: &str) -> Option<&cmacro::VarMacro> {
         self.variable_macros.get(name)
     }
 
+    /// Get a type by its name.
     pub(crate) fn type_by_name(&self, name: &str) -> Option<&TypeId> {
         self.type_names.get(name)
     }

bindgen/ir/function.rs

@@ -10,8 +10,6 @@ use crate::callbacks::{ItemInfo, ItemKind};
 use crate::clang::{self, Attribute};
 use crate::parse::{ClangSubItemParser, ParseError, ParseResult};
 use clang_sys::{self, CXCallingConv};
-use proc_macro2;
-use quote;
 use quote::TokenStreamExt;
 use std::io;
 use std::str::FromStr;

bindgen/ir/item.rs

@@ -20,9 +20,7 @@ use super::ty::{Type, TypeKind};
 use crate::clang;
 use crate::ir::{macro_def::MacroDef, var::Var};
 use crate::parse::{ClangSubItemParser, ParseError, ParseResult};
-use clang_sys;
 use lazycell::LazyCell;
-use regex;
 use std::cell::Cell;
 use std::collections::BTreeSet;
 use std::fmt::Write;

bindgen/ir/var.rs

@@ -21,6 +21,7 @@ pub(crate) enum VarType {
     /// A floating point number.
     Float(f64),
     /// A character.
+    #[allow(unused)]
     Char(u8),
     /// A string, not necessarily well-formed utf-8.
     String(Vec<u8>),