Skip to content

Commit 4786a22

Browse files
bors[bot]matklad
andauthored
Merge #10098
10098: minor: dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
2 parents bda50a1 + f1222e8 commit 4786a22

File tree

2 files changed

+10
-34
lines changed

2 files changed

+10
-34
lines changed

crates/hir_expand/src/lib.rs

+10-30
Original file line numberDiff line numberDiff line change
@@ -666,42 +666,22 @@ pub fn to_fragment_kind(call: &ast::MacroCall) -> FragmentKind {
666666
};
667667

668668
match parent.kind() {
669-
MACRO_ITEMS | SOURCE_FILE => FragmentKind::Items,
670-
MACRO_STMTS => FragmentKind::Statements,
669+
MACRO_ITEMS | SOURCE_FILE | ITEM_LIST => FragmentKind::Items,
670+
MACRO_STMTS | EXPR_STMT | BLOCK_EXPR => FragmentKind::Statements,
671671
MACRO_PAT => FragmentKind::Pattern,
672672
MACRO_TYPE => FragmentKind::Type,
673-
ITEM_LIST => FragmentKind::Items,
673+
674+
ARG_LIST | TRY_EXPR | TUPLE_EXPR | PAREN_EXPR | ARRAY_EXPR | FOR_EXPR | PATH_EXPR
675+
| CLOSURE_EXPR | CONDITION | BREAK_EXPR | RETURN_EXPR | MATCH_EXPR | MATCH_ARM
676+
| MATCH_GUARD | RECORD_EXPR_FIELD | CALL_EXPR | INDEX_EXPR | METHOD_CALL_EXPR
677+
| FIELD_EXPR | AWAIT_EXPR | CAST_EXPR | REF_EXPR | PREFIX_EXPR | RANGE_EXPR | BIN_EXPR => {
678+
FragmentKind::Expr
679+
}
674680
LET_STMT => {
675681
// FIXME: Handle LHS Pattern
676682
FragmentKind::Expr
677683
}
678-
EXPR_STMT => FragmentKind::Statements,
679-
BLOCK_EXPR => FragmentKind::Statements,
680-
ARG_LIST => FragmentKind::Expr,
681-
TRY_EXPR => FragmentKind::Expr,
682-
TUPLE_EXPR => FragmentKind::Expr,
683-
PAREN_EXPR => FragmentKind::Expr,
684-
ARRAY_EXPR => FragmentKind::Expr,
685-
FOR_EXPR => FragmentKind::Expr,
686-
PATH_EXPR => FragmentKind::Expr,
687-
CLOSURE_EXPR => FragmentKind::Expr,
688-
CONDITION => FragmentKind::Expr,
689-
BREAK_EXPR => FragmentKind::Expr,
690-
RETURN_EXPR => FragmentKind::Expr,
691-
MATCH_EXPR => FragmentKind::Expr,
692-
MATCH_ARM => FragmentKind::Expr,
693-
MATCH_GUARD => FragmentKind::Expr,
694-
RECORD_EXPR_FIELD => FragmentKind::Expr,
695-
CALL_EXPR => FragmentKind::Expr,
696-
INDEX_EXPR => FragmentKind::Expr,
697-
METHOD_CALL_EXPR => FragmentKind::Expr,
698-
FIELD_EXPR => FragmentKind::Expr,
699-
AWAIT_EXPR => FragmentKind::Expr,
700-
CAST_EXPR => FragmentKind::Expr,
701-
REF_EXPR => FragmentKind::Expr,
702-
PREFIX_EXPR => FragmentKind::Expr,
703-
RANGE_EXPR => FragmentKind::Expr,
704-
BIN_EXPR => FragmentKind::Expr,
684+
705685
_ => {
706686
// Unknown , Just guess it is `Items`
707687
FragmentKind::Items

crates/tt/src/lib.rs

-4
Original file line numberDiff line numberDiff line change
@@ -277,17 +277,13 @@ pub mod buffer;
277277

278278
#[derive(Debug, PartialEq, Eq, Clone)]
279279
pub enum ExpansionError {
280-
IOError(String),
281-
JsonError(String),
282280
Unknown(String),
283281
ExpansionError(String),
284282
}
285283

286284
impl fmt::Display for ExpansionError {
287285
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
288286
match self {
289-
ExpansionError::IOError(e) => write!(f, "I/O error: {}", e),
290-
ExpansionError::JsonError(e) => write!(f, "JSON decoding error: {}", e),
291287
ExpansionError::Unknown(e) => e.fmt(f),
292288
ExpansionError::ExpansionError(e) => write!(f, "proc macro returned error: {}", e),
293289
}

0 commit comments

Comments
 (0)