Skip to content

Commit 64403de

Browse files
committed
Require 2/3 majority
1 parent 365810a commit 64403de

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/github/nag.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ fn evaluate_pendings() -> DashResult<()> {
395395
proposal.id, why));
396396
}
397397

398-
let majority_complete = num_outstanding_reviews < num_complete_reviews;
398+
let majority_complete = num_outstanding_reviews < 2 * num_complete_reviews;
399399

400400
if num_active_concerns == 0 && majority_complete && num_outstanding_reviews < 3 {
401401
// TODO only record the fcp as started if we know that we successfully commented
@@ -1197,7 +1197,7 @@ impl<'a> RfcBotComment<'a> {
11971197
}
11981198
}
11991199

1200-
msg.push_str("\nOnce a majority of reviewers approve (and at most 2 approvals are outstanding), ");
1200+
msg.push_str("\nOnce two thirds of reviewers approve (and at most 2 approvals are outstanding), ");
12011201
msg.push_str("this will enter its final comment period. ");
12021202
msg.push_str("If you spot a major issue that hasn't been raised ");
12031203
msg.push_str("at any point in this process, please speak up!\n");

0 commit comments

Comments
 (0)