Skip to content

Commit 4451cf9

Browse files
committed
comment out Team.{name, ping} from Team; but keep in rfcbot.toml!
1 parent d139983 commit 4451cf9

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

src/teams.rs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,13 @@ pub struct FcpBehavior {
5656

5757
#[derive(Debug, Deserialize)]
5858
pub struct Team {
59-
// FIXME: The two following first fields don't seem to be used anywhere...
60-
// If this is intended, document why.
61-
name: String,
62-
ping: String,
59+
// FIXME(2018-05-16):
60+
// The two following first fields are not used anymore.
61+
// But they could still be useful. Consider what usage they could have.
62+
63+
//name: String,
64+
//ping: String,
65+
6366
members: Vec<String>,
6467
}
6568

@@ -195,15 +198,15 @@ members = [
195198
cfg.teams().map(|(k, v)| (k.0.clone(), v.clone())).collect();
196199

197200
let avengers = map.get("avengers").unwrap();
198-
assert_eq!(avengers.name, "The Avengers");
199-
assert_eq!(avengers.ping, "marvel/avengers");
201+
//assert_eq!(avengers.name, "The Avengers");
202+
//assert_eq!(avengers.ping, "marvel/avengers");
200203
assert_eq!(avengers.member_logins().collect::<Vec<_>>(),
201204
vec!["hulk", "thor", "thevision", "blackwidow",
202205
"spiderman", "captainamerica"]);
203206

204207
let jsa = map.get("justice-league").unwrap();
205-
assert_eq!(jsa.name, "Justice League of America");
206-
assert_eq!(jsa.ping, "dc-comics/justice-league");
208+
//assert_eq!(jsa.name, "Justice League of America");
209+
//assert_eq!(jsa.ping, "dc-comics/justice-league");
207210
assert_eq!(jsa.member_logins().collect::<Vec<_>>(),
208211
vec!["superman", "wonderwoman", "aquaman", "batman", "theflash"]);
209212

0 commit comments

Comments
 (0)