Skip to content

Commit 42b8d81

Browse files
tmandryMark-Simulacrum
authored andcommitted
Continue showing active FCPs in individual nags
I'd really like to see RFCs in active final comment period that I haven't reviewed yet. Especially since now is my last chance to review them! The current filter was originally added to address #212; I think this filter would have addressed that concern as well.
1 parent 365810a commit 42b8d81

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/nag.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ pub fn individual_nags(username: &str) -> DashResult<(GitHubUser, Vec<Individual
102102

103103
let review_requests = fcp_review_request::table
104104
.inner_join(fcp_proposal::table)
105-
.filter(fcp_proposal::fcp_start.is_null())
105+
.filter(fcp_proposal::fcp_closed.eq(false))
106106
.filter(fcp_review_request::fk_reviewer.eq(user.id))
107107
.filter(fcp_review_request::reviewed.eq(false))
108108
.load::<(FcpReviewRequest, FcpProposal)>(conn)?;

0 commit comments

Comments
 (0)